ports/180662: sysutils/fusefs-libs: add birthtime support

Jan Beich jbeich at tormail.org
Sat Jul 20 00:50:02 UTC 2013


The following reply was made to PR ports/180662; it has been noted by GNATS.

From: Jan Beich <jbeich at tormail.org>
To: Pedro Giffuni <giffunip at tutopia.com>
Cc: bug-followup at FreeBSD.org
Subject: Re: ports/180662: sysutils/fusefs-libs: add birthtime support
Date: Sat, 20 Jul 2013 00:38:06 +0000

 --=-=-=
 Content-Type: text/plain
 Content-Disposition: inline
 
 Pedro Giffuni <giffunip at tutopia.com> writes:
 
 > +--- include/fuse_kernel.h.orig	2013-07-19 12:31:33.000000000 -0500
 > ++++ include/fuse_kernel.h	2013-07-19 12:35:32.000000000 -0500
 > +@@ -134,16 +134,24 @@
 > + 	__u64	atime;
 > + 	__u64	mtime;
 > + 	__u64	ctime;
 > ++#ifdef __FreeBSD__
 > ++	__u64	crtime;
 > ++#endif
 > + 	__u32	atimensec;
 > + 	__u32	mtimensec;
 > + 	__u32	ctimensec;
 > ++#ifdef __FreeBSD__
 > ++	__u32	crtimensec;
 > ++#endif
 > + 	__u32	mode;
 > + 	__u32	nlink;
 > + 	__u32	uid;
 > + 	__u32	gid;
 > + 	__u32	rdev;
 > + 	__u32	blksize;
 > ++#ifndef __FreeBSD__
 > + 	__u32	padding;
 > ++#endif
 > + };
 
 The padding seems wrong. Did you meen the following ?
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: inline; filename=adjust_outsize.diff
 
 --- fusefs-libs/files/extrapatch-fuse-birthtime.diff
 +++ fusefs-libs/files/extrapatch-fuse-birthtime.diff
 @@ -20,11 +20,30 @@
   	__u32	rdev;
   	__u32	blksize;
  +#ifndef __FreeBSD__
 - 	__u32	padding;
 +-	__u32	padding;
 ++	__u32	padding[4];
  +#endif
   };
   
   struct fuse_kstatfs {
 +@@ -339,7 +339,7 @@ enum fuse_notify_code {
 + /* The read buffer is required to be at least 8k, but may be much larger */
 + #define FUSE_MIN_READ_BUFFER 8192
 + 
 +-#define FUSE_COMPAT_ENTRY_OUT_SIZE 120
 ++#define FUSE_COMPAT_ENTRY_OUT_SIZE 136
 + 
 + struct fuse_entry_out {
 + 	__u64	nodeid;		/* Inode ID */
 +@@ -372,7 +372,7 @@ struct fuse_getattr_in {
 + 	__u64	fh;
 + };
 + 
 +-#define FUSE_COMPAT_ATTR_OUT_SIZE 96
 ++#define FUSE_COMPAT_ATTR_OUT_SIZE 112
 + 
 + struct fuse_attr_out {
 + 	__u64	attr_valid;	/* Cache timeout for the attributes */
  --- lib/fuse_lowlevel.c.orig	2012-09-04 05:17:46.000000000 -0500
  +++ lib/fuse_lowlevel.c	2013-07-19 14:11:22.000000000 -0500
  @@ -67,9 +67,15 @@
 
 --=-=-=--


More information about the freebsd-ports-bugs mailing list