ports/180490: net/svnup: insufficient check of $FreeBSD$ lines

[Alexey Markov]

>Number:         180490
>Category:       ports
>Synopsis:       net/svnup: insufficient check of $FreeBSD$ lines
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 12 11:30:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Alexey Markov
>Release:        8.3-RELEASE-p7
>Organization:
JSC Complitex
>Environment:
FreeBSD host.redrat.ru 8.3-RELEASE-p7 FreeBSD 8.3-RELEASE-p7 #0: Thu Apr 4 14:15:05 MSK 2013 redrat at host.redrat.ru:/arc/obj/arc/src/sys/HOST amd64
>Description:
Fore some reason svnup doesn't check $FreeBSD$ line for actual data in it, thus after source tree updating some files has this line truncated, without actual data.
>How-To-Repeat:
Get FreeBSD 8.4-RELEASE distributive media and extract source tree from it to some folder (e.g. /new/1).

Run svnup upon this folder: svnup release -l /new/1

Fetch source tree to another, empty folder: svnup release -l /new/2

Compare files in these folders:

Files /new/1/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 and /new/2/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 differ
Files /new/1/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c and /new/2/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c differ
Files /new/1/sys/mips/rmi/xlr_boot1_console.c and /new/2/sys/mips/rmi/xlr_boot1_console.c differ
Files /new/1/tools/regression/bin/sh/builtins/break3.0 and /new/2/tools/regression/bin/sh/builtins/break3.0 differ

#diff /new/1/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 /new/2/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1
22c22
< .\" $FreeBSD$
---
> .\" $FreeBSD: release/8.4.0/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 235571 2012-05-18 00:02:11Z gjb $
>Fix:
I think that svnup have to check $FreeBSD$ line for correct format and change it to match the line in the repository.

>Release-Note:
>Audit-Trail:
>Unformatted: