ports/180169: graphics/freeimage install wrong links

[Andrea Venturoli]

>Number:         180169
>Category:       ports
>Synopsis:       graphics/freeimage install wrong links
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 01 13:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Andrea Venturoli
>Release:        9.1
>Organization:
NetFence
>Environment:
FreeBSD bane.ventu 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0 r252056: Sun Jun 23 11:57:03 CEST 2013     root at bane.ventu:/usr/obj/usr/src/sys/BANE  i386

>Description:
I first found out about this via portsclean:

#portsclean -L
..
Unreadable file or directory: /usr/local/lib/libfreeimageplus.so.3
Unreadable file or directory: /usr/local/lib/libfreeimageplus.so

So:
ls -l /usr/local/lib|grep freeimage
-rwxr-xr-x   1 root  wheel   3529452 Jul  1 15:02 libfreeimage-3.15.4.so
-rw-r--r--   1 root  wheel   4917684 Jul  1 15:02 libfreeimage.a
lrwxr-xr-x   1 root  wheel        17 Jul  1 15:02 libfreeimage.so -> libfreeimage.so.3
lrwxr-xr-x   1 root  wheel        22 Jul  1 15:02 libfreeimage.so.3 -> libfreeimage-3.15.4.so
-rwxr-xr-x   1 root  wheel   3566560 Jul  1 15:02 libfreeimageplus-3.15.4.so
-rw-r--r--   1 root  wheel   4988200 Jul  1 15:02 libfreeimageplus.a
lrwxr-xr-x   1 root  wheel        23 Jul  1 15:02 libfreeimageplus.so -> libfreeimageplus-3.15.4
lrwxr-xr-x   1 root  wheel        23 Jul  1 15:02 libfreeimageplus.so.3 -> libfreeimageplus-3.15.4

The last two links point to a nonexistent file.



cd /usr/ports/graphics/freeimage ; make install
..
install -m 755 -o root -g wheel libfreeimageplus-3.15.4.so //usr/local/lib
/bin/ln -s libfreeimageplus-3.15.4 /usr/local/lib/libfreeimageplus.so.3
/bin/ln -s libfreeimageplus-3.15.4 /usr/local/lib/libfreeimageplus.so
===>   Running ldconfig
..


So are the last lines in Makefile wrong?
${LN} -s libfreeimageplus-${PORTVERSION} ${PREFIX}/lib/libfreeimageplus.so.3
${LN} -s libfreeimageplus-${PORTVERSION} ${PREFIX}/lib/libfreeimageplus.so
>How-To-Repeat:

>Fix:
Perhaps the last lines in Makefile should be:
${LN} -s libfreeimageplus-${PORTVERSION}.so ${PREFIX}/lib/libfreeimageplus.so.3
${LN} -s libfreeimageplus-${PORTVERSION}.so ${PREFIX}/lib/libfreeimageplus.so


>Release-Note:
>Audit-Trail:
>Unformatted: