ports/175684: [patch] emulators/virtualbox-ose-kmod: Fix KMODDIR installation

[Glen Barber]

>Number:         175684
>Category:       ports
>Synopsis:       [patch] emulators/virtualbox-ose-kmod: Fix KMODDIR installation
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 29 22:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Glen Barber
>Release:        10.0-CURRENT r245748M
>Organization:
>Environment:
FreeBSD nucleus 10.0-CURRENT FreeBSD 10.0-CURRENT #57 r245748M: Mon Jan 28 10:32:02 EST 2013     gjb at nucleus:/usr/obj/usr/src/sys/NUCLEUS  amd64
>Description:
emulators/virtualbox-ose-kmod/Makefile sets KMODDIR to /boot/modules if not set:

 root at nucleus:/usr/ports/emulators/virtualbox-ose-kmod # grep ^KMODDIR Makefile
 KMODDIR?=       /boot/modules

However, KMODDIR is always set, even if not explicitly set by the user:

 root at nucleus:/usr/ports/emulators/virtualbox-ose-kmod # make -V KMODDIR
 /boot/kernel
 root at nucleus:/usr/ports/emulators/virtualbox-ose-kmod # make -C ../qemu -V KMODDIR
 /boot/kernel


>How-To-Repeat:

>Fix:
The attached patch sets KMODDIR=/boot/modules instead of attempting to set to /boot/modules if not set, otherwise users will experience pain when vbox*.ko disappear after a kernel upgrade.

Patch attached with submission follows:

Index: /usr/ports/emulators/virtualbox-ose-kmod/Makefile
===================================================================
--- /usr/ports/emulators/virtualbox-ose-kmod/Makefile	(revision 311188)
+++ /usr/ports/emulators/virtualbox-ose-kmod/Makefile	(working copy)
@@ -45,7 +45,7 @@
 
 PLIST_SUB+=	KMODDIR=${KMODDIR:C,^/,,}
 
-KMODDIR?=	/boot/modules
+KMODDIR=	/boot/modules
 SRC_BASE?=	/usr/src
 
 VBOX_BIN=	${WRKSRC}/out/${KMK_ARCH}/${KMK_BUILDTYPE}/bin/src


>Release-Note:
>Audit-Trail:
>Unformatted: