ports/178185: [maintainer][patch] math/ggobi: build problem with graphviz solved

[Rainer Hurling]

>Number:         178185
>Category:       ports
>Synopsis:       [maintainer][patch] math/ggobi: build problem with graphviz solved
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 26 17:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Rainer Hurling
>Release:        10.0-CURRENT (amd64)
>Organization:
>Environment:
FreeBSD xxx.xxx.xxx 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r249715M: Sun Apr 21 11:16:54 CEST 2013     xxx at xxx.xxx.xxx:/usr/obj/usr/src/sys/XXX  amd64
>Description:
With graphics/graphviz installed, math/ggobi finds this external
installation by its configure script in plugins/GraphLayout. Then it
tries to use it instead of its internal graphviz version and fails when
trying to build the port.

This has been a longstanding problem with ggobi, not detected by tinderbox etc. As a workaround, one had to deinstall graphics/graphviz before building math/ggobi and reinstall it afterwards. That should be solved now.

While here, trimming Makefiles header.
>How-To-Repeat:
Try to build math/ggobi, when graphics/graphviz is installed.
>Fix:
Greg Larkin was so kind to help me with this problem. He looked into it and gave me the hint to post-configure patch the two files. Many thanks to Greg!

Patch attached with submission follows:

diff -Naur ggobi.orig/Makefile ggobi/Makefile
--- ggobi.orig/Makefile	2012-08-03 14:33:50.000000000 +0200
+++ ggobi/Makefile	2013-04-26 18:49:15.000000000 +0200
@@ -1,9 +1,5 @@
-# Ports collection makefile for:   ggobi
-# Date created:        31 January 2010
-# Whom:                rhurlin
-#
-# $FreeBSD: head/math/ggobi/Makefile 300896 2012-07-14 13:54:48Z beat $
-#
+# Created by: Rainer Hurling <rhurlin at gwdg.de>
+# $FreeBSD$
 
 PORTNAME=	ggobi
 PORTVERSION=	2.1.9
@@ -33,6 +29,15 @@
 		${WRKSRC}/src/ggobi-renderer-factory.c \
 		${WRKSRC}/src/ggobi-renderer.c
 
+post-configure:
+# build gets irritated by the presence of an external graphviz version
+	@${REINPLACE_CMD} -e 's|#define HAVE_LIBGVC 1|/* #define HAVE_LIBGVC 1 */|' \
+		${WRKSRC}/plugins/GraphLayout/config.h
+	@${REINPLACE_CMD} -e 's|LIBGVC_CFLAGS = -I${LOCALBASE}/include/graphviz|LIBGVC_CFLAGS =|' \
+		${WRKSRC}/plugins/GraphLayout/Makefile
+	@${REINPLACE_CMD} -e 's|LIBGVC_LIBS = -L${LOCALBASE}/lib/graphviz -lgvc -lgraph -lcdt|LIBGVC_LIBS =|' \
+		${WRKSRC}/plugins/GraphLayout/Makefile
+
 post-install:
 	${MKDIR} ${PREFIX}/etc/xdg/ggobi
 	${INSTALL_DATA} ${WRKSRC}/ggobirc ${PREFIX}/etc/xdg/ggobi/ggobirc.sample


>Release-Note:
>Audit-Trail:
>Unformatted: