ports/178138: [patch] puppet - enable in freebsd service provider is broken

[Bogdan]

>Number:         178138
>Category:       ports
>Synopsis:       [patch] puppet - enable in freebsd service provider is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 25 10:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Bogdan
>Release:        9.1-RELEASE
>Organization:
>Environment:
9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
see https://github.com/puppetlabs/puppet/pull/1527 for explanation and patch

When puppet is asked to enable a service in rc.conf, it adds

apache_enable_enable="YES"

and it keeps saying that it changed 'enable' from false to true every run.


>How-To-Repeat:
create a manifest for a service that isn't in rc.conf with

ensure => running

and apply it. check rc.conf
>Fix:
The commit that fixes this upstream is here: https://github.com/puppetlabs/puppet/pull/1527/files

Patch is attached.

Note that there is a newer version of puppet out, not sure when it was released or if it contains this fix.

Patch attached with submission follows:


--- freebsd.rb.original 2013-04-24 09:40:57.000000000 +0200
+++ freebsd.rb.patched 2013-04-25 10:31:56.000000000 +0200
@@ -41,7 +41,7 @@
def rcvar_name
name = self.rcvar[1]
self.error("No rcvar name found in rcvar") if name.nil?
- name = name.gsub!(/(.*)(_enable)?=(.*)/, '\1')
+ name = name.gsub!(/(.*?)(_enable)?=(.*)/, '\1')
self.error("rcvar name is empty") if name.nil?
self.debug("rcvar name is #{name}")
name 

>Release-Note:
>Audit-Trail:
>Unformatted: