ports/178041: editors/libreoffice: WITH_GCC option should migrate to OptionsNG

[HATANO Tomomi]

>Number:         178041
>Category:       ports
>Synopsis:       editors/libreoffice: WITH_GCC option should migrate to OptionsNG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 22 06:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     HATANO Tomomi
>Release:        9.1-RELEASE-p2
>Organization:
>Environment:
FreeBSD minako 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243826: Tue Dec  4 06:55:39 UTC 2012     root at obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
On 9.1-RELEASE i386, editors/libreoffice built with clang doesn't run at all.
Built with lang/gcc46 runs OK.
(On amd64 machines, this problem doesn't appear.)

Old style WITH_GCC option is left in Makefile.
It should migrate to optionsNG.

>How-To-Repeat:
Build libreoffice on i386 machine and try running.

>Fix:
Apply attached patch.

Patch attached with submission follows:

--- editors/libreoffice/Makefile.orig	2013-04-22 14:18:23.000000000 +0900
+++ editors/libreoffice/Makefile	2013-04-22 14:17:53.000000000 +0900
@@ -181,7 +181,7 @@
 MANCOMPRESSED=	yes
 
 OPTIONS_DEFINE=	CUPS DEBUG GNOME GTK2 GTK3 JAVA KDE4 MERGELIBS MMEDIA PGSQL \
-		SDK SYSTRAY TEST WEBDAV
+		SDK SYSTRAY TEST WEBDAV GCC
 OPTIONS_DEFAULT=CUPS GTK2
 
 JAVA_DESC=	Add java support (XML Filters, macros)
@@ -192,6 +192,7 @@
 SYSTRAY_DESC=	Enable systemtray quickstarter
 TEST_DESC=	Run all regression tests
 WEBDAV_DESC=	Enable webdav protocol
+GCC_DESC=	Use gcc to build
 
 .include <bsd.port.options.mk>
 
@@ -348,7 +349,7 @@
 
 .include <bsd.port.pre.mk>
 
-.if defined(WITH_GCC)
+.if ${PORT_OPTIONS:MGCC}
 USE_GCC=	4.6+
 CONFIGURE_ENV+=	CXXCPP="${CPP}"
 .else


>Release-Note:
>Audit-Trail:
>Unformatted: