ports/178004: games/minecraft-server: [PATCH] bad checksum, bad scheme

[John Marino]

>Number:         178004
>Category:       ports
>Synopsis:       games/minecraft-server: [PATCH] bad checksum, bad scheme
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 20 19:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     John Marino
>Release:        
>Organization:
>Environment:
>Description:
Problem: games/minecraft-server distfile doesn't match checksum
Cause: it looks like the master_sites selected don't use the version number (e.g. 1.4.6) but rather overwrite the file with the latest.  So it's probably pulling version 1.5.1 or something.

Dports solution:
1) pick a different master_site that keeps versions separate
2) I still had to regenerate distinfo because it was 9 bytes different

patch attached -- this is what fixed dports.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2013-02-09 14:41:28.000000000 +0000
+++ Makefile
@@ -3,9 +3,9 @@
 
 PORTNAME=	minecraft-server
 PORTVERSION=	1.4.6
+PORTREVISION=	1
 CATEGORIES=	games java
-MASTER_SITES=	http://s3.amazonaws.com/MinecraftDownload/launcher/ \
-		http://denkrobat.de/minecraft/ \
+MASTER_SITES=	http://assets.minecraft.net/${PORTVERSION:S|.|_|g}/ \
 		http://media-mcw.cursecdn.com/f/f7/:icon
 DISTNAME=	minecraft_server
 DISTFILES=	minecraft_server.jar \
--- distinfo.orig	2013-02-09 14:41:28.000000000 +0000
+++ distinfo
@@ -1,4 +1,4 @@
-SHA256 (minecraft-server/1.4.6/minecraft_server.jar) = 96b7512aead2fb20ddf780d7dd74208d77f209e16058ea8944150179e65b4dd3
-SIZE (minecraft-server/1.4.6/minecraft_server.jar) = 2061638
+SHA256 (minecraft-server/1.4.6/minecraft_server.jar) = 90b3b9cd466abcd6ed9e932e1b81f8e34c5771f536670ed9ac493188b021000b
+SIZE (minecraft-server/1.4.6/minecraft_server.jar) = 2061647
 SHA256 (minecraft-server/1.4.6/Bookshelf.png) = fe5e7f0bbbbe284379cb5e7aed8d539b727a3039f7fe8c64a179e4fc2a0e1821
 SIZE (minecraft-server/1.4.6/Bookshelf.png) = 9674


>Release-Note:
>Audit-Trail:
>Unformatted: