ports/177961: Update port science/veusz to 1.17.1
Ruslan Makhmatkhanov
cvs-src at yandex.ru
Thu Apr 18 16:40:01 UTC 2013
The following reply was made to PR ports/177961; it has been noted by GNATS.
From: Ruslan Makhmatkhanov <cvs-src at yandex.ru>
To: Stas Timokhin <devel at stayan.com>
Cc: bug-followup at FreeBSD.org
Subject: Re: ports/177961: Update port science/veusz to 1.17.1
Date: Thu, 18 Apr 2013 20:31:08 +0400
Hello Stas,
please see the comments below:
> BUILD_DEPENDS= ${PYNUMPY} \
> - ${PYTHON_SITELIBDIR}/PyQt4/QtGui.so:${PORTSDIR}/x11-toolkits/py-qt4-gui
> + ${PYTHON_SITELIBDIR}/PyQt4/QtGui.so:${PORTSDIR}/x11-toolkits/py-qt4-gui \
Please convert PYTHON_SITELIBDIR to PYTHON_PKGNAMEPREFIX too as you do
for py-qt4-svg.
> + ${PYTHON_PKGNAMEPREFIX}/qt4-svg:${PORTSDIR}/graphics/py-qt4-svg
This line has wrong format and it will try to install py-qt4-svg even if
it's already installed. The correct format is following:
${PYTHON_PKGNAMEPREFIX}qt4-svg>0:${PORTSDIR}/graphics/py-qt4-svg
What should be in left side is the actual port name but with no
hardcoded python version, so slash should not be used here. And there
also should be version evaluation (>0 if specific version isn't
important) to not introduce build breakage that I mention above.
> RUN_DEPENDS:= ${BUILD_DEPENDS}
Are you sure that this dependencies are actually needed on build stage?
In most cases they aren't, would you please check? And if they are not
needed for build, just move them in RUN_DEPENDS and drop BUILD_DEPENDS
completely.
> USE_PYTHON= 2.5+
After python24 and python25 removal we tend to set this value to ``yes''
(if port support both python2 and python3) or to -2.7 (this is an
equivalent of python2.x only). Would you please check if your port
supports python3 and correct that line accordingly.
Please update your patch and sent it as an follow-up to this pr. Thank
you for your time.
--
Regards,
Ruslan
Tinderboxing kills... the drives.
More information about the freebsd-ports-bugs
mailing list