ports/177729: [PATCH] sysutils/puppet: puppet agent failed when connecting to puppet master

[Edward]

>Number:         177729
>Category:       ports
>Synopsis:       [PATCH] sysutils/puppet: puppet agent failed when connecting to puppet master
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 09 03:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Edward
>Release:        FreeBSD 9.1-RELEASE
>Organization:
>Environment:
FreeBSD puppet-testing-port-01.example.com 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
puppet agent display the following error message when connecting to puppet master:
Info: Retrieving plugin
Error: /File[/var/puppet/lib]: Could not evaluate: Could not retrieve information from environment production source(s) puppet://puppet-testing-port-01.example.com/plugins
Info: Caching catalog for puppet-testing-port-02.example.com
Info: Applying configuration version '1365200455'

This is because the puppet master (puppet-testing-port01.example.com) has a missing directory /usr/local/etc/puppet/modules, which doesn't create by default. The attached diff of sysutils/puppet Makefile will create the directory /usr/local/etc/puppet/modules which do away the error message.
>How-To-Repeat:
On a fresh installation of sysutils/puppet (without /usr/local/etc/puppet/modules) on puppet master (puppet-testing-port01.example.com), then try to connect puppet agent (puppet-testing-port02.example.com) with it.
>Fix:


Patch attached with submission follows:

--- Makefile.original	2013-04-09 11:04:19.000000000 +0800
+++ Makefile	2013-04-09 11:05:33.000000000 +0800
@@ -95,6 +95,7 @@
 		--vardir=/var/lib/puppet \
 		--logdir=/var/log/puppet \
 		> ${ETCDIR}/puppet.conf-dist
+	${MKDIR} -p ${ETCDIR}/modules
 	@${ECHO} ${RUBY_SITELIBDIR}/puppet.rb | \
 		${SED} 's,^${PREFIX}/,,' >> ${TMPPLIST}
 	@${ECHO} ${RUBY_SITELIBDIR}/semver.rb | \


>Release-Note:
>Audit-Trail:
>Unformatted: