ports/173660: [Ports: www/tomcat7]: error on init script when using custom classpath

[Victor Balada Diaz]

>Number:         173660
>Category:       ports
>Synopsis:       [Ports: www/tomcat7]: error on init script when using custom classpath
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 16 14:50:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Victor Balada Diaz
>Release:        FreeBSD 7.4-RELEASE-p3 i386
>Organization:
>Environment:
	
>Description:
If you configure a custom classpath on /etc/rc.conf like:

tomcat7_classpath="/classes/foo.jar:/classes/bar.jar"

It will fail because the assignment have a missing ':'. For it to work
you should specify ':' like:

tomcat7_classpath=":/classes/foo.jar:/classes/bar.jar"

Which is non-obvious.

>How-To-Repeat:
	
>Fix:
	The following patch fixes it.

--- tomcat7.patch begins here ---
Index: files/tomcat7.in
===================================================================
--- files/tomcat7.in	(revision 307487)
+++ files/tomcat7.in	(working copy)
@@ -110,7 +110,7 @@
 	-wait ${_tomcat_wait} \
 	-outfile '${_tomcat_stdout}' \
 	-errfile '${_tomcat_stderr}' \
-	-classpath '%%TOMCAT_HOME%%/bin/bootstrap.jar:%%LOCALBASE%%/share/java/classes/commons-daemon.jar:%%TOMCAT_HOME%%/bin/tomcat-juli.jar${_tomcat_classpath}' \
+	-classpath '%%TOMCAT_HOME%%/bin/bootstrap.jar:%%LOCALBASE%%/share/java/classes/commons-daemon.jar:%%TOMCAT_HOME%%/bin/tomcat-juli.jar:${_tomcat_classpath}' \
 	-Djava.util.logging.manager=${_tomcat_logging_manager} \
 	-Djava.util.logging.config.file='${_tomcat_logging_config}' \
 	${_tomcat_java_opts} \
--- tomcat7.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: