ports/166536: [maintainer update]

[Fernando]

>Number:         166536
>Category:       ports
>Synopsis:       [maintainer update]
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 31 16:00:23 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Fernando
>Release:        9.0-RELEASE
>Organization:
>Environment:
FreeBSD hammer 9.0-RELEASE FreeBSD 9.0-RELEASE #6: Thu Mar 15 21:48:00 CET 2012     root at hammer:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
I originally sent this as a new port[1] using ${INSTALL_DATA} to install the library archive but, at some time that changed to ${INSTALL_LIB}.

If we use INSTALL_LIB, the archive gets stripped so important symbols as "ON::Begin" (the initialization function) are removed from the static library.

I fall back to ${INSTALL_DATA} instead of overriding ${STRIP}

[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=164376
>How-To-Repeat:
cd /usr/ports/graphics/opennurbs && make
cd work/opennurbs_20111122

Execute these two commands to notice the difference:

readelf --syms libopenNURBS.a | grep -i begin
readelf --syms /usr/local/lib/libopenNURBS.a | grep -i begin

>Fix:
Apply the attached patch.

Patch attached with submission follows:

diff -ruN /usr/ports/graphics/opennurbs/Makefile opennurbs/Makefile
--- /usr/ports/graphics/opennurbs/Makefile	2012-03-22 18:36:16.000000000 +0100
+++ opennurbs/Makefile	2012-03-31 17:41:51.000000000 +0200
@@ -27,7 +27,7 @@
 	@${MV} ${WRKSRC}/opennurbs_version.h.tmp ${WRKSRC}/opennurbs_version.h
 
 do-install:
-	@${INSTALL_LIB} ${WRKSRC}/libopenNURBS.a ${PREFIX}/lib
+	@${INSTALL_DATA} ${WRKSRC}/libopenNURBS.a ${PREFIX}/lib
 	@${MKDIR} ${EXAMPLESDIR}
 .for i in brep dump read roundtrip userdata write
 	@${INSTALL_PROGRAM} ${WRKSRC}/example_${i}/example_${i} ${EXAMPLESDIR}


>Release-Note:
>Audit-Trail:
>Unformatted: