ports/166176: sysutils/mount.app Tagged BROKEN - possible fix

[Martin MATO]

>Number:         166176
>Category:       ports
>Synopsis:       sysutils/mount.app Tagged BROKEN - possible fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 16 09:20:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Martin MATO
>Release:        Freebsd 9.0
>Organization:
>Environment:
FreeBSD pcmartino2.univ-perp.fr 9.0-STABLE FreeBSD 9.0-STABLE #0: Tue Feb 28 16:30:02 CET 2012     root at pcmartino2.univ-perp.fr:/usr/obj/usr/src/sys/TEST  i386
>Description:
On 06 Mar 2012 sysutils/mount.app was Marked BROKEN because it does not compile with x11-wm/windowmaker 0.95 (that is true)

>How-To-Repeat:
to have a brief  review of the problem;
Untag BROKEN entry in sysutils/mount.app/Makefile
make

and then the failure appears:

Making all in EXTRAS
cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include     -O2 -pipe -fno-strict-aliasing -std=gnu89   -I/usr/local/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/local/include  -DUSE_XPM -c `test -f 'mount.c' || echo './'`mount.c
cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include     -O2 -pipe -fno-strict-aliasing -std=gnu89   -I/usr/local/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/local/include  -DUSE_XPM -c `test -f 'fstab.c' || echo './'`fstab.c
cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include     -O2 -pipe -fno-strict-aliasing -std=gnu89   -I/usr/local/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/local/include  -DUSE_XPM -c `test -f 'properties.c' || echo './'`properties.c
properties.c: In function 'saveProperties':
properties.c:451: error: too many arguments to function 'WMWritePropListToFile'
*** Error code 1

Stop in /usr/ports/sysutils/mount.app/work/mountapp-3.0/src.
*** Error code 1

>Fix:
The problem lies here, i think :
http://lists.windowmaker.org/dev/msg00985.html

where the function 'WMWritePropListToFile' was simplified and no longer wait for a third entry.

I generated a patch (included)
applied it, and then successfully builded, installed and run the application; on both 9.0-STABLE and 8.3 PRERELEASE stations. (i386 and AMD64)

If it is a correct approch, could you please include the patch and fix the port entry?

Thanks for your time.

Martin MATO

Patch attached with submission follows:

--- work/mountapp-3.0/src/properties.c.ori	2012-03-15 13:29:24.000000000 +0100
+++ work/mountapp-3.0/src/properties.c	2012-03-15 13:30:09.000000000 +0100
@@ -448,7 +448,7 @@
         WMReleasePropList(mpProp);
     }
 
-    if (WMWritePropListToFile(props, getFileName(), FALSE) == FALSE)
+    if (WMWritePropListToFile(props, getFileName()) == FALSE)
         printf("Error occurred synchronizing proplist\n");
 
     WMReleasePropList(props);


>Release-Note:
>Audit-Trail:
>Unformatted: