ports/170007: [PATCH] dns/unbound Incorrect use of empty()

[Chris Rees]

>Number:         170007
>Category:       ports
>Synopsis:       [PATCH] dns/unbound Incorrect use of empty()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 19 21:10:11 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Chris Rees
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD pegasus.bayofrum.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Sun Apr 29 12:29:02 BST 2012 root at pegasus.bayofrum.net:/usr/obj/usr/src/sys/PEGASUS amd64


	
>Description:
	.if empty() in a Makefile should not have a $ in;

	correct:
	.if empty(FOO)

	incorrect:
	.if empty(${FOO})
>How-To-Repeat:
	
>Fix:

	Submitted by Alexey Kouznetsov

--- patch.txt begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 301190)
+++ Makefile	(working copy)
@@ -88,7 +88,7 @@
 CONFIGURE_ARGS+=--with-libevent=no
 .endif
 
-.if empty(${PORT_OPTIONS:MTHREADS})
+.if empty(PORT_OPTIONS:MTHREADS)
 CONFIGURE_ARGS+=--without-pthreads
 .endif
 
--- patch.txt ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: