ports/174758: ports-mgmt/portlint: support USE_GCC=yes

Gerald Pfeifer gerald at pfeifer.com
Fri Dec 28 03:10:01 UTC 2012


>Number:         174758
>Category:       ports
>Synopsis:       ports-mgmt/portlint: support USE_GCC=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 28 03:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Gerald Pfeifer
>Release:        
>Organization:
>Environment:
>Description:
	A few days ago, we added USE_GCC=yes as another (and now 
	preferred form of USE_GCC).

	The patch below is a strawman of getting this supported by
	portlint.  I went ahead and made USE_GCC=any and USE_GCC=yes
	a distinct check, so that we can become stricter in filtering
	unsupported options of USE_GCC later on that someone might use.
>How-To-Repeat:
>Fix:

--- portlint.pl	2012-12-28 02:29:16.000000000 +0100
+++ portlint.new	2012-12-28 02:28:58.000000000 +0100
@@ -2035,7 +2035,9 @@
 	if ($whole =~ /^USE_GCC[?:]?=\s*(.*)$/m) {
 		my $lineno = &linenumber($`);
 		my $gcc_val = $1;
-		if ($gcc_val =~ /3\.[234]\+/) {
+		if ($gcc_val eq 'any' || $gcc_val eq 'yes') {
+			# Just accept these two.
+		} elsif ($gcc_val =~ /3\.[234]\+/) {
 			&perror("WARN", $file, $lineno, "USE_GCC=3.2+, USE_GCC=3.3+, ".
 				"and USE_GCC=3.4+ are noops on all currently (and future) ".
 				"supported versions of FreeBSD.  Do not use them.");
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list