ports/174725: graphics/libGL graphics/libGLU graphics/libGLw: disable-gallium-intel bug

[John Marino]

>Number:         174725
>Category:       ports
>Synopsis:       graphics/libGL graphics/libGLU graphics/libGLw: disable-gallium-intel bug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 26 23:00:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     John Marino
>Release:        
>Organization:
>Environment:
>Description:
I believe there are three identical bugs in:
graphics/libGL
graphics/libGLU
graphics/libGLw

Looking at the history, it looks like they were introduced as part of PR#169874 and later PR#171301

Specifically this code was added to all three:
+.if ${ARCH} != "amd64" || ${ARCH} != "i386"
+CONFIGURE_ARGS+=--disable-gallium-intel
+.endif

As ${ARCH} can only be one value, this boolean logic evaluates to "true" in 100% of the cases.  For example, if ${ARCH} == "amd64", then it doesn't equal "i386" and evaluates true.

So ${ARCH} could be "amd64", "i386", or *any other value* and "--disable-gallium-intel" will be added to CONFIGURE_ARGS in every case.
>How-To-Repeat:

>Fix:
I believe this is likely what the original author was going for:

.if !(${ARCH} == "amd64" || ${ARCH} == "i386")
CONFIGURE_ARGS+=--disable-gallium-intel
.endif


(I am assuming gallium-intel should only be disabled for non-x86)


>Release-Note:
>Audit-Trail:
>Unformatted: