ports/174376: [patch] audio/audacity: fix build with clang

[Mark Atkinson]

>Number:         174376
>Category:       ports
>Synopsis:       [patch] audio/audacity: fix build with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 11 20:40:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Mark Atkinson
>Release:        FreeBSD 10.0-CURRENT
>Organization:
>Environment:
FreeBSD 10.0-CURRENT #15 r243027
>Description:
Audacity has a link time failure during compilation in libnyquist with clang as the base compiler:


./lib-src/libnyquist.a(fftlib.o): In function `fftrecurs':
nyquist/ffts/src/fftlib.c:(.text+0x139): undefined reference to `bfstages'
nyquist/ffts/src/fftlib.c:(.text+0x303): undefined reference to `bfstages'
./lib-src/libnyquist.a(fftlib.o): In function `ffts1':
nyquist/ffts/src/fftlib.c:(.text+0x382): undefined reference to `bitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0x496): undefined reference to `bfR4'
nyquist/ffts/src/fftlib.c:(.text+0x4c7): undefined reference to `bfstages'
./lib-src/libnyquist.a(fftlib.o): In function `ifftrecurs':
nyquist/ffts/src/fftlib.c:(.text+0x849): undefined reference to `ibfstages'
nyquist/ffts/src/fftlib.c:(.text+0xa13): undefined reference to `ibfstages'
./lib-src/libnyquist.a(fftlib.o): In function `iffts1':
nyquist/ffts/src/fftlib.c:(.text+0xac3): undefined reference to `scbitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0xbdf): undefined reference to `ibfR4'
nyquist/ffts/src/fftlib.c:(.text+0xc13): undefined reference to `ibfstages'
nyquist/ffts/src/fftlib.c:(.text+0xdaa): undefined reference to `ifft8pt'
./lib-src/libnyquist.a(fftlib.o): In function `rffts1':
nyquist/ffts/src/fftlib.c:(.text+0xe57): undefined reference to `scbitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0xf66): undefined reference to `bfR4'
nyquist/ffts/src/fftlib.c:(.text+0xf97): undefined reference to `bfstages'
nyquist/ffts/src/fftlib.c:(.text+0xfd5): undefined reference to `frstage'
nyquist/ffts/src/fftlib.c:(.text+0x11a6): undefined reference to `rfft8pt'
./lib-src/libnyquist.a(fftlib.o): In function `riffts1':
nyquist/ffts/src/fftlib.c:(.text+0x1285): undefined reference to `ifrstage'
nyquist/ffts/src/fftlib.c:(.text+0x12a0): undefined reference to `scbitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0x13c0): undefined reference to `ibfR4'
nyquist/ffts/src/fftlib.c:(.text+0x13f3): undefined reference to `ibfstages'
nyquist/ffts/src/fftlib.c:(.text+0x165a): undefined reference to `rifft8pt'
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [../audacity] Error 1
gmake[1]: Leaving directory `/usr/ports/audio/audacity/work/audacity-src-2.0.2/src'
gmake: *** [audacity] Error 2
*** [do-build] Error code 1


>How-To-Repeat:
make on recent current/ports tree:
>Fix:
$ svn diff Makefile
Index: Makefile
===================================================================
--- Makefile    (revision 308234)
+++ Makefile    (working copy)
@@ -186,4 +186,6 @@
        @${REINPLACE_CMD} -e 's|libresample.a -lsamplerate $(LIBS)|libresample.a $(LIBS)|' ${WRKSRC}/lib-src/libresample/Makefile.in
 .endif
 
+       @${REINPLACE_CMD} -e 's|inline void|static inline void|' ${WRKSRC}/lib-src/libnyquist/nyquist/ffts/src/fftlib.c
+
 .include <bsd.port.mk>

>Release-Note:
>Audit-Trail:
>Unformatted: