ports/171117: [PATCH] security/knock: Duplicated flags

[Lung-Pin Chang]

>Number:         171117
>Category:       ports
>Synopsis:       [PATCH] security/knock: Duplicated flags
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 27 13:30:16 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Lung-Pin Chang
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD Archon.iamben.csie.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:
/etc/rc.subr already loads ${name}_flags as part of command line arguments.

Putting $knockd_flags into $command_args causes the flags to be duplicated twice.

e.g.
root         75681   0.0  0.0  12324   1064  ??  Rs    9:18PM     0:00.88 /usr/local/bin/knockd -d -d 



Port maintainer (sbz at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- knock-0.5_1,1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/security/knock/Makefile /home/iamben/tmp/ports/security/knock/Makefile
--- /usr/ports/security/knock/Makefile	2012-08-06 07:19:36.000000000 +0800
+++ /home/iamben/tmp/ports/security/knock/Makefile	2012-08-27 21:17:31.089871996 +0800
@@ -7,6 +7,7 @@
 
 PORTNAME=	knock
 PORTVERSION=	0.5
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	security
 MASTER_SITES=	http://www.zeroflux.org/proj/knock/files/ \
diff -ruN --exclude=CVS /usr/ports/security/knock/files/knockd.in /home/iamben/tmp/ports/security/knock/files/knockd.in
--- /usr/ports/security/knock/files/knockd.in	2012-08-06 07:19:36.000000000 +0800
+++ /home/iamben/tmp/ports/security/knock/files/knockd.in	2012-08-27 21:17:16.335874460 +0800
@@ -27,7 +27,6 @@
 : ${knockd_flags="-d"}
 
 command="%%PREFIX%%/bin/knockd"
-command_args=${knockd_flags}
 pidfile="/var/run/knockd.pid"
 required_files=${knockd_conf}
 
--- knock-0.5_1,1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: