ports/170483: [patch] Correct multimedia/gstreamer Dependency Declaration

[A.J. Kehoe IV (Nanoman)]

>Number:         170483
>Category:       ports
>Synopsis:       [patch] Correct multimedia/gstreamer Dependency Declaration
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 08 16:50:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     A.J. Kehoe IV (Nanoman)
>Release:        9.0
>Organization:
Nanoman's Company
>Environment:
FreeBSD localhost 9.0-RELEASE-p3 FreeBSD 9.0-RELEASE-p3 #0: Tue Jun 12 02:52:29 UTC 2012     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
The FreeBSD port multimedia/gstreamer uses automatic detection to declare an optional dependency.  This causes problems for port and package management.
>How-To-Repeat:

>Fix:
I've attached a patch that corrects this by using the method suggested in the FreeBSD Porter's Handbook on the "Dependencies" page under "Problems Caused by Automatic Dependencies":

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html

Patch attached with submission follows:

--- ports/multimedia/gstreamer/Makefile.old	2012-06-27 08:35:03.000000000 -0400
+++ ports/multimedia/gstreamer/Makefile	2012-08-08 12:38:49.467664000 -0400
@@ -45,9 +45,12 @@
 	gst-typefind-${GST_VERSION}.1 gst-xmlinspect-${GST_VERSION}.1 \
 	gst-xmllaunch-${GST_VERSION}.1
 
+OPTIONS_DEFINE=	LIBCHECK
+LIBCHECK_DESC=	Enable Check support
+
 .include <bsd.port.pre.mk>
 
-.if (exists(${LOCALBASE}/lib/libcheck.a) || defined(WITH_CHECK))
+.if ${PORT_OPTIONS:MLIBCHECK}
 LIB_DEPENDS+=	check.0:${PORTSDIR}/devel/libcheck
 PLIST_SUB+=	CHECK=""
 .else


>Release-Note:
>Audit-Trail:
>Unformatted: