ports/167385: [patch] netatalk 2.2.2 insists on using sendfile

[Daniel Becker]

>Number:         167385
>Category:       ports
>Synopsis:       [patch] netatalk 2.2.2 insists on using sendfile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 28 07:10:07 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Daniel Becker
>Release:        9.0-RELEASE
>Organization:
>Environment:
FreeBSD razzems.Stanford.EDU 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC 2012     root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
After updating to version 2.2.2, Netatalk uses sendfile to transmit data to the client. As documented in kern/141305, this causes severe performance issues for Netatalk shares hosted on ZFS volumes, manifesting itself in extremely low network transfer speed, while causing excessive disk I/O.

Please consider exposing the --disable-sendfile configure switch introduced in Netatalk 2.2.2 through the port's config options.
>How-To-Repeat:
- create Netatalk share on ZFS
- read any files from the share
- watch transfer rate and server-side disk I/O
>Fix:
Create a config option for disabling the use of sendfile. Patch attached.

Patch attached with submission follows:

--- Makefile	2012-04-28 00:04:10.224230833 -0700
+++ Makefile.new	2012-04-27 23:50:53.283177302 -0700
@@ -39,7 +39,8 @@
 		TIMELORD	"Enable Timelord network time service" off \
 		KRB5		"Enable Kerberos V UAM" off \
 		ZEROCONF	"Enable Zeroconf (Bonjour) support" on \
-		LDAP		"Enable LDAP support" off
+		LDAP		"Enable LDAP support" off \
+		SENDFILE	"Enable sendfile support" off
 
 FILES=		AppleVolumes.default AppleVolumes.system afpd.conf netatalk.conf
 LINKS=		unbin unhex unsingle hqx2bin single2bin macbinary \
@@ -119,6 +120,12 @@
 CONFIGURE_ARGS+=	--without-ldap
 .endif
 
+.if defined (WITH_SENDFILE)
+CONFIGURE_ARGS+=	--enable-sendfile
+.else
+CONFIGURE_ARGS+=	--disable-sendfile
+.endif
+
 .if ${OSVERSION} < 800031
 PLIST_SUB+=	ATFUNCS="@comment "
 .else



>Release-Note:
>Audit-Trail:
>Unformatted: