ports/161857: [patch] emulators/qemu-devel: respect NOPORTDOCS, even if it's empty

Nali Toja nalitoja at gmail.com
Fri Oct 21 05:40:11 UTC 2011


>Number:         161857
>Category:       ports
>Synopsis:       [patch] emulators/qemu-devel: respect NOPORTDOCS, even if it's empty
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 21 05:40:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Nali Toja
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
gmake has slightly different semantics for ifdef/ifndef, the variable
tested *has to* have a value to be treated as defined.

`ifdef VARIABLE-NAME'
     The `ifdef' form takes the _name_ of a variable as its argument,
     [...]
     The value of that variable has a non-empty value, the TEXT-IF-TRUE
     is effective; otherwise, the TEXT-IF-FALSE, if any, is effective.
`ifndef VARIABLE-NAME'
     If the variable VARIABLE-NAME has an empty value, the TEXT-IF-TRUE
     is effective; otherwise, the TEXT-IF-FALSE, if any, is effective.
>How-To-Repeat:
$ make install deinstall NOPORTDOCS= PREFIX=/foo
$ find /foo ! -type d
/foo/share/doc/qemu/qemu-doc.html
/foo/share/doc/qemu/qemu-tech.html
>Fix:
--- nodocs.diff begins here ---
Index: emulators/qemu-devel/Makefile
===================================================================
RCS file: /a/.csup/ports/emulators/qemu-devel/Makefile,v
retrieving revision 1.128
diff -u -p -r1.128 Makefile
--- emulators/qemu-devel/Makefile	13 Oct 2011 19:08:30 -0000	1.128
+++ emulators/qemu-devel/Makefile	21 Oct 2011 03:40:20 -0000
@@ -140,7 +161,7 @@ RUN_DEPENDS+=	${LOCALBASE}/share/qemu/se
 .endif
 
 .if defined(NOPORTDOCS)
-MAKE_ARGS+=	NOPORTDOCS=${NOPORTDOCS}
+MAKE_ARGS+=	NOPORTDOCS=1
 .else
 BUILD_DEPENDS+=	texi2html:${PORTSDIR}/textproc/texi2html
 .endif
--- nodocs.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list