ports/157044: x11-toolkits/slgtk: fails to start

[Jilles Tjoelker]

>Number:         157044
>Category:       ports
>Synopsis:       x11-toolkits/slgtk: fails to start
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 14 15:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Jilles Tjoelker
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD *** 8.2-STABLE FreeBSD 8.2-STABLE #4 r219306M: Sat Mar  5 15:04:21 CET 2011     jilles@***:/usr/obj/***/freebsd/stable/8/sys/GENERIC  i386

gtk-2.22.1_1
gdk-pixbuf-2.22.1
glib-2.26.1_1
>Description:
Apparently slgtk is using obsolete names from old versions of gtk.
The accompanying programs do not start.
>How-To-Repeat:
A command like

imdisplay /usr/local/share/gtk-2.0/demo/apple-red.png

(passing the path to an existing image file) gives an error like

GDK_Shift_L is undefined
/usr/local/share/slsh/local-packages/gtk.sl:216:<top-level>:Undefined Name
Traceback: evalfile
Traceback: evalfile

and does not display a window.

Starting the example using

slsh /usr/local/share/examples/slgtk/main.sl

fails similarly.
>Fix:
The following patch appears to fix imdisplay, but it does not fix the
example (it now complains about GDK_1). It may be wrong.

--- patch-packages__gtk.sl begins here ---
--- ./packages/gtk.sl.orig	2010-02-03 23:43:27.000000000 +0100
+++ ./packages/gtk.sl	2011-05-14 16:28:22.000000000 +0200
@@ -213,7 +213,7 @@
 
 private define shift_chain(slave, event, chain) % {{{
 {
-   if (event.keyval != GDK_Shift_L and event.keyval != GDK_Shift_R)
+   if (event.keyval != GDK_KEY_Shift_L and event.keyval != GDK_KEY_Shift_R)
 	return FALSE;
 
    chain.shift = (event.type == GDK_KEY_PRESS);
--- patch-packages__gtk.sl ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: