ports/155201: [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV added WITH_BINUTILS

[bf]

>Number:         155201
>Category:       ports
>Synopsis:       [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV added WITH_BINUTILS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 02 16:40:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     bf
>Release:        
>Organization:
>Environment:
>Description:
Various tools from devel/binutils are supposed to be added to the CONFIGURE_ENV when WITH_BINUTILS is defined.  However, when a port relies on bsd.autotools.mk, bsd.php.mk, or bsd.xorg.mk to define GNU_CONFIGURE instead of declaring this variable explicitly in the port Makefile, these tools may not be added.





>How-To-Repeat:

>Fix:
To fix this, change the way that USE_BINUTILS modifies CONFIGURE_ENV: like other knobs, make additions regardless of whether GNU_CONFIGURE is defined, subject only to a new optional blacklist variable BINUTILS_NO_CONFIGURE_ENV, which is analogous to the existing BINUTILS_NO_MAKE_ENV. This eliminates the as-yet-unused variable BINUTILS_CONFIGURE, and also adds the tools to the CONFIGURE_ENV for ports that use HAS_CONFIGURE.


Patch attached with submission follows:

Index: /home/u1/pwrk/ports/Mk/bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.673
diff -u -r1.673 bsd.port.mk
--- /home/u1/pwrk/ports/Mk/bsd.port.mk	25 Feb 2011 16:52:05 -0000	1.673
+++ /home/u1/pwrk/ports/Mk/bsd.port.mk	2 Mar 2011 16:11:29 -0000
@@ -1752,10 +1752,11 @@
 BUILD_DEPENDS+=	${LOCALBASE}/bin/as:${PORTSDIR}/devel/binutils
 BINUTILS?=	ADDR2LINE AR AS CPPFILT GPROF LD NM OBJCOPY OBJDUMP RANLIB \
 	READELF SIZE STRINGS
+BINUTILS_NO_CONFIGURE_ENV?=
 BINUTILS_NO_MAKE_ENV?=
 . for b in ${BINUTILS}
 ${b}=	${LOCALBASE}/bin/${b:C/PP/++/:L}
-.  if defined(GNU_CONFIGURE) || defined(BINUTILS_CONFIGURE)
+.  if ${BINUTILS_NO_CONFIGURE_ENV:M${b}} == ""
 CONFIGURE_ENV+=	${b}="${${b}}"
 .  endif
 .  if ${BINUTILS_NO_MAKE_ENV:M${b}} == ""


>Release-Note:
>Audit-Trail:
>Unformatted: