ports/154174: [PATCH] net/xrdp: [SUMMARIZE CHANGES]

[Mark Felder]

>Number:         154174
>Category:       ports
>Synopsis:       [PATCH] net/xrdp: [SUMMARIZE CHANGES]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 20 20:20:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Mark Felder
>Release:        FreeBSD 8.2-RC2 amd64
>Organization:
>Environment:
System: FreeBSD nas.feld.me 8.2-RC2 FreeBSD 8.2-RC2 #0: Wed Jan 12 17:02:35 UTC 2011
>Description:
This patch was on the SF forums. It fixes a high CPU bug.

Portlint is not happy with the port; leaving that up to 
the maintainer.

Also, pulling a new cvs version might fix things as well
but I'm not familiar with the project and do not know 
what revision would be best to use.

Added file(s):
- files/patch-common__trans.c

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
Use xrdp and you'll hit the high CPU bug.

>Fix:

--- xrdp-0.6.0.20101009cvs_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net/xrdp/Makefile /tmp/xrdp/Makefile
--- /usr/ports/net/xrdp/Makefile	2010-12-04 01:33:03.000000000 -0600
+++ /tmp/xrdp/Makefile	2011-01-20 14:09:21.000000000 -0600
@@ -7,7 +7,7 @@
 
 PORTNAME=	xrdp
 PORTVERSION=	0.6.0.20101009cvs
-#PORTREVISION=	0
+PORTREVISION=	1
 CATEGORIES=	net
 MASTER_SITES=	http://www.club.kyutech.ac.jp/~meta/distfiles/
 
diff -ruN --exclude=CVS /usr/ports/net/xrdp/files/patch-common__trans.c /tmp/xrdp/files/patch-common__trans.c
--- /usr/ports/net/xrdp/files/patch-common__trans.c	1969-12-31 18:00:00.000000000 -0600
+++ /tmp/xrdp/files/patch-common__trans.c	2011-01-20 14:09:04.000000000 -0600
@@ -0,0 +1,34 @@
+--- ./common/trans.c-orig	2010-05-04 09:37:22.000000000 +0200
++++ ./common/trans.c		2010-06-15 09:13:05.000000000 +0200
+@@ -214,6 +214,7 @@
+         /* error */
+         self->status = TRANS_STATUS_DOWN;
+         rv = 1;
++        break;
+       }
+     }
+     else if (rcvd == 0)
+@@ -221,6 +222,7 @@
+       /* error */
+       self->status = TRANS_STATUS_DOWN;
+       rv = 1;
++      break;
+     }
+     else
+     {
+@@ -271,6 +273,7 @@
+         /* error */
+         self->status = TRANS_STATUS_DOWN;
+         rv = 1;
++        break;
+       }
+     }
+     else if (sent == 0)
+@@ -278,6 +281,7 @@
+       /* error */
+       self->status = TRANS_STATUS_DOWN;
+       rv = 1;
++      break;
+     }
+     else
+     {
--- xrdp-0.6.0.20101009cvs_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: