ports/153956: squid31: squid_radius_auth does not send identifier to RADIUS server

[Dmitry]

>Number:         153956
>Category:       ports
>Synopsis:       squid31: squid_radius_auth does not send identifier to RADIUS server
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 13 16:50:08 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry
>Release:        8.2-PRERELEASE
>Organization:
>Environment:
FreeBSD freetm.tp-local.ru 8.2-PRERELEASE FreeBSD 8.2-PRERELEASE #0: Tue Jan 11 20:08:49 UTC 2011     root at freetm.tp-local.ru:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
pkg_info -xI squid
squid-3.1.10        HTTP Caching Proxy

squid_radius_auth does not send  specifyed by identifier field of config file.

Attached patch fixes this problem.

I've sent this patch to Squid-Cache.org
>How-To-Repeat:
Add identifier to radius configuration file.
Launch wireshark to sniff traffic to RADIUS server
run 
echo 'user password' | /usr/local/libexec/squid/squid_radius_auth -f "path to radius config"

>Fix:
patch appended 

Patch attached with submission follows:

--- helpers/basic_auth/squid_radius_auth/squid_rad_auth.c.orig	2011-01-13 20:05:08.000000000 +0000
+++ helpers/basic_auth/squid_radius_auth/squid_rad_auth.c	2011-01-13 20:06:19.000000000 +0000
@@ -387,6 +387,7 @@
         *ptr++ = len + 2;
         memcpy(ptr, identifier, len);
         ptr += len;
+	total_length += len + 2;
     } else {
         *ptr++ = PW_NAS_IP_ADDRESS;
         *ptr++ = 6;


>Release-Note:
>Audit-Trail:
>Unformatted: