ports/153648: [patch] net/xmlrpc-c-devel: build tools by default

[Anonymous]

>Number:         153648
>Category:       ports
>Synopsis:       [patch] net/xmlrpc-c-devel: build tools by default
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 03 14:00:27 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
because curl-config passes -rpath=/usr/lib:... they may not work with
libstdc++ from lang/gcc*

  $ xmlrpc_pstream
  /libexec/ld-elf.so.1: /usr/lib/libstdc++.so.6: version GLIBCXX_3.4.11 required by /usr/local/bin/xmlrpc_pstream not found

because libwww-config passes -L/usr/lib they may not compile with
libstdc++ from lang/gcc*

  c++ -o xml-rpc-api2cpp  xml-rpc-api2cpp.o DataType.o XmlRpcFunction.o XmlRpcClass.o SystemProxy.o  -L/.../work/xmlrpc-c-1.23.2/src/cpp -lxmlrpc_cpp -lxmlrpc_server -Lblddir/src -Lblddir/lib/libutil -lxmlrpc_client -lxmlrpc -lxmlrpc_util -L/usr/local/lib -lwwwxml -lxmltok -lxmlparse -lwwwzip -lwwwssl -lwwwinit -lwwwapp -lwwwhtml -lwwwtelnet -lwwwnews -lwwwhttp -lwwwmime -lwwwgopher -lwwwftp -lwwwfile -lwwwdir -lwwwcache -lwwwstream -lwwwmux -lwwwtrans -lwwwcore -lwwwutils -lmd5 -lz -L/usr/lib -lssl -lcrypto -L/usr/local/lib -lcurl -L/usr/local/lib -rpath=/usr/local/lib -L/usr/local/lib -lcares -lidn -lssl -lcrypto -lz -L/.../work/xmlrpc-c-1.23.2/lib/expat/xmlparse -lxmlrpc_xmlparse -L/.../work/xmlrpc-c-1.23.2/lib/expat/xmltok   -lxmlrpc_xmltok
  /usr/local/lib/libwwwcore.so: warning: warning: tmpnam() possibly used unsafely; consider using mkstemp()
  /usr/local/lib/libwwwcore.so: warning: warning: tempnam() possibly used unsafely; consider using mkstemp()
  xml-rpc-api2cpp.o: In function `std::ctype<char>::widen(char) const':
  /usr/local/lib/gcc45/include/c++/bits/locale_facets.h:868: undefined reference to `std::ctype<char>::_M_widen_init() const'
  /usr/local/lib/gcc45/include/c++/bits/locale_facets.h:868: undefined reference to `std::ctype<char>::_M_widen_init() const'
  /usr/local/lib/gcc45/include/c++/bits/locale_facets.h:868: undefined reference to `std::ctype<char>::_M_widen_init() const'
  /usr/local/lib/gcc45/include/c++/bits/locale_facets.h:868: undefined reference to `std::ctype<char>::_M_widen_init() const'
  /usr/local/lib/gcc45/include/c++/bits/locale_facets.h:868: undefined reference to `std::ctype<char>::_M_widen_init() const'
  xml-rpc-api2cpp.o:/usr/local/lib/gcc45/include/c++/bits/locale_facets.h:868: more undefined references to `std::ctype<char>::_M_widen_init() const' follow
  collect2: ld returned 1 exit status
>Description:
build cli tools like non-devel port does
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: net/xmlrpc-c-devel/Makefile
===================================================================
RCS file: /a/.cvsup/ports/net/xmlrpc-c-devel/Makefile,v
retrieving revision 1.52
diff -u -p -r1.52 Makefile
--- net/xmlrpc-c-devel/Makefile	4 Dec 2010 07:33:03 -0000	1.52
+++ net/xmlrpc-c-devel/Makefile	3 Jan 2011 13:56:29 -0000
@@ -17,7 +17,8 @@ COMMENT=	XML-RPC library for C and C++
 
 OPTIONS=	DEBUG "Compile with debugging information" off \
 		CURL "Compile with curl support" on \
-		LIBWWW "Compile with libwww support" on
+		LIBWWW "Compile with libwww support" on \
+		TOOLS "Compile tools" on
 
 CONFLICTS=	xmlrpc-epi-0.* xmlrpc-c-[0-9]*
 
@@ -33,6 +34,8 @@ MAKE_ARGS=	LIBTOOL="${LIBTOOL}" \
 MAKE_JOBS_UNSAFE=	yes
 USE_LDCONFIG=	yes
 
+MAN1=		xml-rpc-api2txt.1 xml-rpc-api2cpp.1
+
 LICENSE=	BSD
 
 .include <bsd.port.pre.mk>
@@ -55,7 +58,18 @@ CONFIGURE_ARGS+=	--enable-libwww-client
 CONFIGURE_ARGS+=	--disable-libwww-client
 .endif
 
+.if defined(WITH_TOOLS)
+CONFIGURE_ARGS+=	--enable-tools
+PLIST_SUB+=	TOOLS=""
+.else
+CONFIGURE_ARGS+=	--disable-tools
+PLIST_SUB+=	TOOLS="@comment "
+.endif
+
 .if defined(WITHOUT_LIBWWW) && defined(WITHOUT_CURL)
+. if defined(WITH_TOOLS)
+IGNORE=		${PORTNAME} tools require either curl or libwww support
+. endif
 PLIST_SUB+=	CLIENT="@comment "
 .else
 PLIST_SUB+=	CLIENT=""
Index: net/xmlrpc-c-devel/pkg-plist
===================================================================
RCS file: /a/.cvsup/ports/net/xmlrpc-c-devel/pkg-plist,v
retrieving revision 1.16
diff -u -p -r1.16 pkg-plist
--- net/xmlrpc-c-devel/pkg-plist	16 Sep 2010 14:10:35 -0000	1.16
+++ net/xmlrpc-c-devel/pkg-plist	3 Jan 2011 13:54:57 -0000
@@ -1,4 +1,10 @@
+%%TOOLS%%bin/xml-rpc-api2cpp
+%%TOOLS%%bin/xml-rpc-api2txt
+%%TOOLS%%bin/xmlrpc
 bin/xmlrpc-c-config
+%%TOOLS%%bin/xmlrpc_cpp_proxy
+%%TOOLS%%bin/xmlrpc_pstream
+%%TOOLS%%bin/xmlrpc_transport
 include/XmlRpcCpp.h
 include/xmlrpc-c/abyss.h
 include/xmlrpc-c/abyss_unixsock.h
Index: net/xmlrpc-c-devel/files/patch-tools-xmlrpc_pstream-xmlrpc_pstream.cpp
===================================================================
RCS file: net/xmlrpc-c-devel/files/patch-tools-xmlrpc_pstream-xmlrpc_pstream.cpp
diff -N net/xmlrpc-c-devel/files/patch-tools-xmlrpc_pstream-xmlrpc_pstream.cpp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ net/xmlrpc-c-devel/files/patch-tools-xmlrpc_pstream-xmlrpc_pstream.cpp	3 Jan 2011 12:53:48 -0000
@@ -0,0 +1,11 @@
+--- tools/xmlrpc_pstream/xmlrpc_pstream.cpp~
++++ tools/xmlrpc_pstream/xmlrpc_pstream.cpp
+@@ -15,8 +15,6 @@
+ #include "xmlrpc-c/girerr.hpp"
+ using girerr::throwf;
+ 
+-#include <features.h>  // for __BEGIN_DECLS
+-
+ __BEGIN_DECLS
+ #include "dumpvalue.h"  /* An internal Xmlrpc-c header file ! */
+ __END_DECLS
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: