ports/154942: rc.d/thrift starts no matter what the rc.conf setting

[Erik Steigler]

>Number:         154942
>Category:       ports
>Synopsis:       rc.d/thrift starts no matter what the rc.conf setting
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 21 17:00:18 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Erik Steigler
>Release:        FreeBSD 8.1-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD erik.dev.okcupid.com 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #0 r209508: Thu Jun 24 14:57:46 EDT 2010 root at erik.dev.okcupid.com:/usr/obj/vol/data0/svn/Freebsd_8/sys/GENERIC amd64


  
>Description:
  The scribe rc script seems to be missing the defination to check if it is enabled in /etc/rc.conf. This causes it to automatically start on boot and if someone runs /usr/local/etc/rc.d/scribe start. This also causes an unexpected operator error when it is run:
[root at erik /usr/local/etc/rc.d]# grep scribe /etc/rc.conf
[root at erik /usr/local/etc/rc.d]# ./scribe start
[: /usr/sbin/daemon: unexpected operator
Starting scribe.

>How-To-Repeat:
  1. Install net/scribe
  2. Issue /usr/local/etc/rc.d/scribe start

>Fix:

The attached patch adds the rcvar variable which seems to fix the problem.

--- scribe_rc.patch begins here ---
--- ./files/scribe.in.orig	2011-02-21 11:11:51.000000000 -0500
+++ ./files/scribe.in	2011-02-21 11:12:20.000000000 -0500
@@ -13,6 +13,8 @@
 command="/usr/sbin/daemon -p ${pidfile} %%PREFIX%%/bin/scribed"
 procname="%%PREFIX%%/bin/scribed"
 
+rcvar=`set_rcvar`
+
 load_rc_config "$name"
 : ${scribe_enable="NO"}
 : ${scribe_flags=""}
--- scribe_rc.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: