ports/163610: Patch for proxy regression in net/liferea 1.8.0

[Fabian Keil]

>Number:         163610
>Category:       ports
>Synopsis:       Patch for proxy regression in net/liferea 1.8.0
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 25 15:00:26 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Fabian Keil
>Release:        HEAD
>Organization:
>Environment:
FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #386: Sat Dec 24 13:19:40 CET 2011     fk at r500.local:/usr/obj/usr/src/sys/ZOEY  amd64

>Description:
There's a regression in Liferea 1.8.0 that causes it to ignore the proxy settings for requests made though the feed item viewer. The configured HTTP proxy is used to update the feeds, though.

This has been fixed upstream in:
http://liferea.git.sourceforge.net/git/gitweb.cgi?p=liferea/liferea;a=patch;h=137604683770cae900d5835befefd95c65866cd7;hp=b509074806afbf5f0ee3f36db8e112c1ea20cdac

The attached patch "backports" this fix.
>How-To-Repeat:
Configure a HTTP proxy in Liferea, read a feed item with embedded images and watch the network traffic.

In environments where direct HTTP requests from common applications are redirected or blocked and DNS requests are made through Tor, the image requests will also take longer than usual and occasionally timeout.
>Fix:
Apply the patch (with -p0).

You may want to shorten the patch it creates in net/liferea/files to the src/ui/liferea_htmlview.c chunk. I kept it as-is so comparing with the source is easier. It was created with: git format-patch --no-prefix 137604683^..137604683

Patch attached with submission follows:

diff -ruN .zfs/snapshot/2011-12-25/net/liferea/Makefile net/liferea/Makefile
--- .zfs/snapshot/2011-12-25/net/liferea/Makefile	2011-12-18 16:07:30.467969699 +0100
+++ net/liferea/Makefile	2011-12-25 15:09:06.975384655 +0100
@@ -7,6 +7,7 @@
 
 PORTNAME=	liferea
 PORTVERSION=	1.8.0
+PORTREVISION=	1
 CATEGORIES=	net gnome
 MASTER_SITES=	SF/${PORTNAME}/Liferea%20Stable/${PORTVERSION}
 
diff -ruN .zfs/snapshot/2011-12-25/net/liferea/files/patch-proxy-fix-1376046 net/liferea/files/patch-proxy-fix-1376046
--- .zfs/snapshot/2011-12-25/net/liferea/files/patch-proxy-fix-1376046	1970-01-01 01:00:00.000000000 +0100
+++ net/liferea/files/patch-proxy-fix-1376046	2011-12-25 14:53:17.000000000 +0100
@@ -0,0 +1,45 @@
+From 137604683770cae900d5835befefd95c65866cd7 Mon Sep 17 00:00:00 2001
+From: Lars Lindner <lars.lindner at gmail.com>
+Date: Wed, 14 Dec 2011 18:18:02 +0100
+Subject: [PATCH] Fixes proxy preference not affecting the HTML widget.
+
+---
+ ChangeLog                 |    8 ++++++++
+ src/ui/liferea_htmlview.c |    5 +++++
+ 2 files changed, 13 insertions(+), 0 deletions(-)
+
+diff --git ChangeLog ChangeLog
+index 251bdb9..12724e5 100644
+--- ChangeLog
++++ ChangeLog
+@@ -1,3 +1,11 @@
++2011-12-??  ???
++
++	Version 1.8.1
++
++	* Fixes proxy preference not affecting the HTML widget.
++	  (reported by Chris Siebenmann)
++
++
+ 2011-12-10  Lars Lindner <lars.lindner at gmail.com>
+ 
+ 	Version 1.8.0
+diff --git src/ui/liferea_htmlview.c src/ui/liferea_htmlview.c
+index 7642c3a..afb20f8 100644
+--- src/ui/liferea_htmlview.c
++++ src/ui/liferea_htmlview.c
+@@ -181,6 +181,11 @@ liferea_htmlview_new (gboolean forceInternalBrowsing)
+ 	g_signal_connect (network_monitor_get (), "proxy-changed",
+ 	                  G_CALLBACK (liferea_htmlview_proxy_changed),
+ 	                  htmlview);
++
++	if (NULL != network_get_proxy_host ()) {
++		debug0 (DEBUG_NET, "Setting initial HTML widget proxy...");
++		liferea_htmlview_proxy_changed (network_monitor_get (), htmlview);
++	}
+ 	
+ 	return htmlview;
+ }
+-- 
+1.7.8
+


>Release-Note:
>Audit-Trail:
>Unformatted: