ports/160012: [maintainer-update] [patch] (ports) net-p2p/lopster portlint cleanup

[Conrad J. Sabatier]

>Number:         160012
>Category:       ports
>Synopsis:       [maintainer-update] [patch] (ports) net-p2p/lopster portlint cleanup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 23 00:20:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Conrad J. Sabatier
>Release:        FreeBSD 9.0-BETA1 amd64
>Organization:
>Environment:
System: FreeBSD serene.no-ip.org 9.0-BETA1 FreeBSD 9.0-BETA1 #5: Mon Aug 22 01:17:18 CDT 2011 conrads at serene.no-ip.org:/usr/obj/usr/src/sys/CUSTOM amd64

>Description:
	Update net-p2p/lopster to conform to portlint's recommendations.

	In addition:

	o Add explicit dependency handling for flac
	o Modify pre-everything output to be a little clearer for less
	  experienced ports users

>How-To-Repeat:
	N/A
>Fix:
	Patch below.

--- lopster-patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net-p2p/lopster/Makefile,v
retrieving revision 1.44
diff -u -r1.44 Makefile
--- Makefile	13 Aug 2011 06:47:33 -0000	1.44
+++ Makefile	22 Aug 2011 22:41:35 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	lopster
 PORTVERSION=	1.2.2
-PORTREVISION=	8
+PORTREVISION=	9
 CATEGORIES=	net-p2p
 MASTER_SITES=	SF \
 		http://lopster.sourceforge.net/download/
@@ -19,10 +19,19 @@
 USE_GMAKE=	yes
 USE_GNOME=	gtk12
 CONFIGURE_ARGS=	--with-pthread=yes
-CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib"
+CONFIGURE_ENV=	LDFLAGS="-L${LOCALBASE}/lib"
+CPPFLAGS+=	"-I${LOCALBASE}/include"
 
 .include <bsd.port.pre.mk>
 
+.if exists(${LOCALBASE}/lib/libFLAC.so.10)
+WITH_FLAC=	yes
+.endif
+
+.if defined(WITH_FLAC)
+LIB_DEPENDS+=	FLAC.10:${PORTSDIR}/audio/flac
+.endif
+
 .if exists(${LOCALBASE}/lib/libogg.so.7)
 WITH_OGG=	yes
 .endif
@@ -38,11 +47,14 @@
 .endif
 
 pre-everything::
+.ifndef WITH_FLAC
+	@${ECHO_MSG} "You can specify WITH_FLAC=yes to include FLAC support"
+.endif
 .ifndef WITH_OGG
-	@${ECHO_MSG} "You can specify WITH_OGG to include Ogg support"
+	@${ECHO_MSG} "You can specify WITH_OGG=yes to include Ogg support"
 .endif
 .ifndef WITHOUT_ZLIB
-	@${ECHO_MSG} "You can specify WITHOUT_ZLIB to disable compression for old servers"
+	@${ECHO_MSG} "You can specify WITHOUT_ZLIB=yes to disable compression for old servers"
 .endif
 
 post-patch:
--- lopster-patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: