ports/151124: OpenBGPD exists if an interface is removed or created

[Melissa Jenkins]

>Number:         151124
>Category:       ports
>Synopsis:       OpenBGPD exists if an interface is removed or created
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 30 20:30:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Melissa Jenkins
>Release:        8.0-RELEASE-p3
>Organization:
-
>Environment:
FreeBSD manch1.streamapn.com 8.0-RELEASE-p3 FreeBSD 8.0-RELEASE-p3 #3: Sat Jun  5 12:56:03 UTC 2010     root at XXXX:/usr/obj/usr/src/sys/SFIP-AMD-8_0  amd64
>Description:
OpenBGPD exits (apparently cleanly) when changes to the IP addressing occur on an GRE & GIF interfaces 

Log shows the same exit codes as a clean shutdown.




>How-To-Repeat:
Running OpenBGPD with the following configuration

===>>> openbgpd-4.6.20100227

bgpd.conf:                                                                                                                           
AS 64570                                      
fib-update yes
listen on 192.168.1.2                                    
log updates
network inet static
network inet connected
neighbor 192.168.1.1 {
    announce all
}

bgpd -v -v -v -v -d -f bgpd.conf

<startup stuff removed>

Wait for startup, then remove an existing interface
eg: 
ifconfig gre1 destroy

bgpd logs the following:
route decision engine exiting
neighbor 192.168.1.129 (XXX): state change Established -> Idle, reason: Stop
neighbor 192.168.1.1 (YYYY): state change Established -> Idle, reason: Stop
session engine exiting
kernel routing table decoupled
Terminating

Same happens when you configure new addresses on an existing interface
ifconfig gre2 create
(still fine)
ifconfig gre10 inet 172.30.1.1 10.0.5.1
(exits)

ifconfig gif1 inet 172.30.1.1 10.0.4.1
will also cause it to exit

adding or removing an alias from a real interface doesn't appear to cause problems.

Also, if you have a minimal configuration file containing only AS & listen on with nothing else it will still exit in the previous cases

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: