ports/151788: [PATCH] x11/xscreensaver 5.12 gltext gobbles memory

[John Marshall]

>Number:         151788
>Category:       ports
>Synopsis:       [PATCH] x11/xscreensaver 5.12 gltext gobbles memory
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 27 22:30:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     John Marshall
>Release:        FreeBSD 8.1-RELEASE-p1 i386
>Organization:
Riverwillow Pty Ltd
>Environment:
System: FreeBSD rwpc12 8.1-RELEASE-p1 FreeBSD 8.1-RELEASE-p1 #2: Tue Oct 12 11:30:43 AEDT 2010 root at rwpc12:/usr/obj/usr/src/sys/RWPC12 i386


	
>Description:

Following upgrade of this port from 5.11 to 5.12 the gltext screensaver
would exhaust memory resources and then...

  rwpc12 kernel: pid 34420 (gltext), ..., was killed: out of swap space

I contacted the author, Jamie Zawinski, who promptly provided the patch
to hacks/glx/tube.c below.

>How-To-Repeat:

Installing x11/xscreensaver 5.12 on a Pentium III with 512MB RAM
triggered this problem.  I didn't try on a larger system.

>Fix:

The following patch upgrades the port to include the author's patch.

Files touched:

  - Makefile --> Bump PORTREVISION
  - files/patch-hacks_glx_tube.c --> Added

--- xscreensaver-5.12.diff begins here ---
diff -urN xscreensaver.orig/Makefile xscreensaver/Makefile
--- xscreensaver.orig/Makefile	2010-10-18 16:53:41.000000000 +1100
+++ xscreensaver/Makefile	2010-10-28 08:56:46.000000000 +1100
@@ -7,6 +7,7 @@
 
 PORTNAME=	xscreensaver
 PORTVERSION=	5.12
+PORTREVISION=	1
 CATEGORIES?=	x11
 MASTER_SITES=	http://www.jwz.org/xscreensaver/ \
 		http://dougbarton.us/Downloads/
diff -urN xscreensaver.orig/files/patch-hacks_glx_tube.c xscreensaver/files/patch-hacks_glx_tube.c
--- xscreensaver.orig/files/patch-hacks_glx_tube.c	1970-01-01 10:00:00.000000000 +1000
+++ xscreensaver/files/patch-hacks_glx_tube.c	2010-10-27 15:24:18.000000000 +1100
@@ -0,0 +1,11 @@
+--- hacks/glx/tube.c.orig	2010-08-23 13:39:51.000000000 +1000
++++ hacks/glx/tube.c	2010-10-27 15:22:07.000000000 +1100
+@@ -181,6 +181,8 @@
+         glDrawArrays ((wire_p ? GL_LINE_LOOP : GL_TRIANGLE_FAN), 0, out);
+       }
+ 
++  free(array);
++
+   return polys;
+ }
+ 
--- xscreensaver-5.12.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: