ports/151266: [PATCH] emulators/xsystem35: syntax error in Makefile

[Jilles Tjoelker]

>Number:         151266
>Category:       ports
>Synopsis:       [PATCH] emulators/xsystem35: syntax error in Makefile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 06 20:30:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Jilles Tjoelker
>Release:        FreeBSD 8.1-STABLE i386
>Organization:
MCGV Stack
>Environment:
any
>Description:
The port Makefile has a stray "done" keyword.

Our sh(1) has sort of allowed this, but this lets clearly wrong scripts
through and has poorly defined and inconsistent behaviour; therefore I
would like to change sh(1) to make such stray keywords an error.
>How-To-Repeat:
Inspect the Makefile and/or build with a stricter sh(1).
>Fix:
Apply this patch to the port Makefile.

--- emulators-xsystem35-syntaxfix.patch begins here ---
--- ports/emulators/xsystem35/Makefile.orig	2010-09-15 20:34:24.000000000 +0200
+++ ports/emulators/xsystem35/Makefile	2010-10-06 22:04:06.000000000 +0200
@@ -72,8 +72,7 @@
 post-patch:
 	${FIND} ${WRKSRC}/src -type f |\
 	${XARGS} ${GREP} -l '<SDL/SDL' /dev/null |\
-	${XARGS} ${REINPLACE_CMD} -e 's,<SDL/,<,'; \
-	done
+	${XARGS} ${REINPLACE_CMD} -e 's,<SDL/,<,'
 
 pre-configure:
 	(cd ${WRKSRC}/libltdl; ${AUTOCONF})
--- emulators-xsystem35-syntaxfix.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: