ports/146807: Incorrect LIB_DEPENDS in print/hplip

[Peter Jeremy]

>Number:         146807
>Category:       ports
>Synopsis:       Incorrect LIB_DEPENDS in print/hplip
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 21 21:30:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Peter Jeremy
>Release:        FreeBSD 8.0-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD m3.vk2pj.dyndns.org 8.0-STABLE FreeBSD 8.0-STABLE #1: Sat Mar 27 10:41:17 EST 2010 root at m3.vk2pj.dyndns.org:/usr/obj/usr/src/sys/m3 i386

>Description:
	print/hplip has "cups.2:${PORTSDIR}/print/cups-base" in LIB_DEPENDS
	but libsane.so.2 is actually installed by print/cups-client.  If
	cups-client is already installed but some other parts of cups-base
	are not installed the the build of print/hplip will fail.

	I ran into this because one of the cups-base dependencies failed
	but when I corrected that problem and restarted the hplip build,
	it then skipped installing the rest of cups-base.

                  already been installed before the cups build exploded.
	
[07:02:13 @peter] I have just bumped into a ports glitch.  I was building
                  print/hplip, which had grown the dependency tree hplip ->
                  cups-base -> ghostscript8 -> png which exploded because I
                  still had the old png installed.  I upgraded png and
                  restarted.  This time, hplip thought all the dependencies were
                  in place and started to build.  It got partway through and
                  exploded because some cups headers were missing.
[07:04:07 @peter] The problem is that hplip has

	
>How-To-Repeat:
	Remove all CUPS-related ports.
	cd /usr/ports/print/cups-client && make install
	cd /usr/ports/print/hplip && make
	This fails with:
...
pe -march=pentium3 -fno-strict-aliasing -c -o hpcups-HPCupsFilter.o `test -f 'prnt/hpcups/HPCupsFilter.cpp' || echo './'`prnt/hpcups/HPCupsFilter.cpp
In file included from prnt/hpcups/HPCupsFilter.h:34,
                 from prnt/hpcups/HPCupsFilter.cpp:31:
prnt/hpcups/CommonDefinitions.h:41:25: error: cups/raster.h: No such file or directory
In file included from prnt/hpcups/HPCupsFilter.cpp:31:
prnt/hpcups/HPCupsFilter.h:100: error: 'cups_page_header2_t' has not been declared
prnt/hpcups/HPCupsFilter.h:101: error: 'cups_raster_t' has not been declared
prnt/hpcups/HPCupsFilter.h:102: error: 'cups_page_header2_t' has not been declared
prnt/hpcups/HPCupsFilter.h:104: error: 'cups_page_header2_t' has not been declared
prnt/hpcups/HPCupsFilter.cpp:233: error: 'DRIVER_ERROR HPCupsFilter::startPage' is not a static member of 'class HPCupsFilter'
prnt/hpcups/HPCupsFilter.cpp:233: error: 'cups_page_header2_t' was not declared in this scope
prnt/hpcups/HPCupsFilter.cpp:233: error: 'cups_header' was not declared in this scope
prnt/hpcups/HPCupsFilter.cpp:234: error: expected ',' or ';' before '{' token
*** Error code 1
1 error
*** Error code 1

Stop in /usr/ports/print/hplip.

>Fix:
	hplip should include a BUILD_DEPENDS on something that is
	directly installed by cups-base.


>Release-Note:
>Audit-Trail:
>Unformatted: