ports/143035: strobe core dump

[Jonathan Hanna]

>Number:         143035
>Category:       ports
>Synopsis:       strobe core dump
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 20 21:40:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Hanna
>Release:        9.0-CURRENT
>Organization:
>Environment:
9.0-CURRENT FreeBSD 9.0-CURRENT #1 r201473  amd64
>Description:
security/strobe allocates and zeros a buffer, but fails to zero all of it.
>How-To-Repeat:
Make sure malloc is set up return non-zero memory, run strobe.
>Fix:
Add this as patch-ab in security/strobe/files:

--- strobe.c.orig       2010-01-20 13:12:21.273531991 -0800
+++ strobe.c    2010-01-20 13:14:14.567760910 -0800
@@ -1297,7 +1297,7 @@
        exit (1);
     }
     port_descs=(struct port_desc_s **) Smalloc(sizeof(struct port_descs_s *) * 65536);
-    memset(port_descs, 0, 65536);
+    memset(port_descs, 0, sizeof(struct port_descs_s *) * 65536);
     while (fgets (lbuf, sizeof (lbuf), fh))
     {
        char *p;

>Release-Note:
>Audit-Trail:
>Unformatted: