ports/142381: [Patch]ports-mgmt/portlint:Fix the bug when it check apache

[Wen Heping]

>Number:         142381
>Category:       ports
>Synopsis:       [Patch]ports-mgmt/portlint:Fix the bug when it check apache
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 06 15:10:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Wen Heping
>Release:        FreeBSD 9.0-Current
>Organization:
ChangAn Middle School
>Environment:
>Description:
When portslint check the ports which depends on ports such as p5-Apache-*,
it always mistake it as apache13 or apache20 apache22, then it will produce 
the fatal error message while the ports has no problem.

For example:

fb9$ cd /usr/ports/www/p5-HTML-Mason
fb9$ portlint
FATAL: Makefile: do not depend on any apache port in *_DEPENDS directly.  Instead use USE_APACHE=VERSION, where VERSION can be found in ${PORTSDIR}/Mk/bsd.apache.mk.
FATAL: Makefile: do not depend on any apache port in *_DEPENDS directly.  Instead use USE_APACHE=VERSION, where VERSION can be found in ${PORTSDIR}/Mk/bsd.apache.mk.
2 fatal errors and 0 warnings found.


But actually p5-HTML-Mason has no problem.

The bug was caused by the regular ~m/apache/i in the source, remove the "i"
could fix the bug.

>How-To-Repeat:
fb9$ cd /usr/ports/www/p5-HTML-Mason
fb9$ portlint
FATAL: Makefile: do not depend on any apache port in *_DEPENDS directly.  Instead use USE_APACHE=VERSION, where VERSION can be found in ${PORTSDIR}/Mk/bsd.apache.mk.
FATAL: Makefile: do not depend on any apache port in *_DEPENDS directly.  Instead use USE_APACHE=VERSION, where VERSION can be found in ${PORTSDIR}/Mk/bsd.apache.mk.
2 fatal errors and 0 warnings found.

>Fix:


Patch attached with submission follows:

--- portlint.pl.orig	2010-01-06 22:52:39.000000000 +0800
+++ portlint.pl	2010-01-06 22:52:53.000000000 +0800
@@ -1213,7 +1213,7 @@
 			}
 
 			# Check for direct dependency on apache.
-			if ($m{'dep'} =~ /apache/i) {
+			if ($m{'dep'} =~ /apache/) {
 				&perror("FATAL", $file, -1, "do not depend on any apache ".
 					"port in *_DEPENDS directly.  ".
 					"Instead use USE_APACHE=VERSION, where VERSION can be ".


>Release-Note:
>Audit-Trail:
>Unformatted: