ports/144044: [PATCH] www/firefox: Makefile.webplugins target order bug

[Dmitry Marakasov]

>Number:         144044
>Category:       ports
>Synopsis:       [PATCH] www/firefox: Makefile.webplugins target order bug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 17 17:10:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 8.0-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Tue Nov 24 22:31:59 MSK 2009
>Description:
I've got a report that my port graphics/gnash doesn't install with the following error:

> ERROR: The "/usr/local/lib/browser_plugins/gnash" in WEBPLUGINS_DIR is
> either a typo or no longer exists. Please make a bug report to
> amdmi3 at FreeBSD.org (maintainer).

The problem is likely in Makefile.webplugins, as it has the following dependency line:

post-install: webplugins-post-install

however gnash installs plugins in post-install, thus the order is
broken - webplugins-post-install is ran before the plugins are
installed. The installation is reported to be fixed after making
gnash port install plugins in pre-install instead.

I really wonder why this hadn't shown itself in a tinderbox and why
I can't reproduce it locally, however Makefile.webplugins logic should
be fixed to run webplugins-post-install after any installation tasks
that may be run by a port.

Port maintainer (gecko at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted: