ports/143979: [PATCH] Portupgrade should not install build dependencies when only using packages

[Bryan Drewery]

>Number:         143979
>Category:       ports
>Synopsis:       [PATCH] Portupgrade should not install build dependencies when only using packages
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 16 01:50:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Bryan Drewery
>Release:        7.2
>Organization:
>Environment:
>Description:
When using -PP and only using packages, there's no need to install BUILD_DEPS, EXTRACT_DEPS, PATCH_DEPS or FETCH_DEPS as the package has already been built.
>How-To-Repeat:
pkg_delete -r '*'
portinstall -PP someport
This will needlessly install stuff like gmake, automake, gsed, etc.
>Fix:
Patch attached.

Patch attached with submission follows:

--- bin/portupgrade.orig	2010-02-15 19:14:22.000000000 -0600
+++ bin/portupgrade	2010-02-15 19:19:25.000000000 -0600
@@ -828,8 +828,12 @@ end
 # Returns:
 #      Set: all recursive depends list
 def get_all_depends(origin, parents_list = nil)
+  if $use_packages_only
+    depends_vars = %w{LIB_DEPENDS RUN_DEPENDS}
+  else
   depends_vars = %w{FETCH_DEPENDS EXTRACT_DEPENDS PATCH_DEPENDS
 		      BUILD_DEPENDS LIB_DEPENDS RUN_DEPENDS}
+  end
 
   unless $depends.has_key?(origin)
     depends = Set.new


>Release-Note:
>Audit-Trail:
>Unformatted: