ports/143473: [PATCH] www/davical Add Missing RUN_DEPENDS php5-iconv

[John Marshall]

>Number:         143473
>Category:       ports
>Synopsis:       [PATCH] www/davical Add Missing RUN_DEPENDS php5-iconv
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 02 10:10:00 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     John Marshall
>Release:        FreeBSD 8.0-RELEASE-p2 i386
>Organization:
Riverwillow Pty Ltd
>Environment:
System: FreeBSD rwsrv03.mby.riverwillow.net.au 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Mon Jan 11 05:45:16 AEDT 2010 root at rwsrv03.mby.riverwillow.net.au:/build/obj/usr/src/sys/RWSRV03 i386

>Description:

The port does not include a RUN_DEPENDS entry for the runtime dependency converters/php5-iconv.
After successful installation of the port, calendar clients are unable to communicate with the server.

>How-To-Repeat:

1. Build and install the www/davical port on a system which does not
   already have converters/php5-iconv installed.

2. Attempt to access the calendar server from a client.

3. Notice entries like the following in the web server log file.

   rwpc12.mby.riverwillow.net.au - - [02/Feb/2010:19:17:47 +1100] "PROPFIND /caldav/caldav.php/john/home/ HTTP/1.1" 500 -

4. Notice the following from php cli on the server.

   rwsrv03> php caldav.php
   PHP Notice:  Undefined index:  SERVER_ADDR in /usr/local/www/davical/inc/always.php on line 19
   PHP Fatal error:  Call to undefined function iconv() in /usr/local/share/awl/inc/AWLUtilities.php on line 463

>Fix:

Include converters/php5-iconv in RUN_DEPENDS in the port's Makefile so
that php5-iconv is available to the davical application at runtime.

--- davical-Makefile.diff begins here ---
--- Makefile.orig	2010-02-02 19:41:43.000000000 +1100
+++ Makefile	2010-02-02 19:43:38.000000000 +1100
@@ -19,7 +19,8 @@
 		${SITE_PERL}/YAML.pm:${PORTSDIR}/textproc/p5-YAML \
 		${SITE_PERL}/${PERL_ARCH}/DBD/Pg.pm:${PORTSDIR}/databases/p5-DBD-Pg \
 		${LOCALBASE}/bin/pwgen:${PORTSDIR}/sysutils/pwgen \
-		php-libawl>=0.37:${PORTSDIR}/devel/php-libawl
+		php-libawl>=0.37:${PORTSDIR}/devel/php-libawl \
+		${PORTSDIR}/converters/php5-iconv
 
 NO_BUILD=	yes
 
--- davical-Makefile.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: