ports/149645: [patch] devel/gnulib: don't preserve owner/group, install `top' directory

[Anonymous]

>Number:         149645
>Category:       ports
>Synopsis:       [patch] devel/gnulib: don't preserve owner/group, install `top' directory
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 14 14:00:13 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
USER = holo
LOCALBASE = /usr/pkg
>Description:
`cp -p' preserves owner/group when the port built by a regular user and
installed by root via SU_CMD.
>How-To-Repeat:
$ find $(make -V DATADIR) -ls | fgrep -v root
198583       61 drwxr-xr-x   13 holo             holo                  954 Jul  4 06:04 /usr/pkg/share/gnulib/lib
199953        2 -rw-r--r--    1 holo             holo                   27 Jul  4 06:04 /usr/pkg/share/gnulib/lib/posixver.h
199900       12 -rw-r--r--    1 holo             holo                 9805 Jul  4 06:04 /usr/pkg/share/gnulib/lib/gettext.h
200242        4 -rw-r--r--    1 holo             holo                 1709 Jul  4 06:04 /usr/pkg/share/gnulib/lib/dummy.c
199904       27 -rw-r--r--    1 holo             holo                36634 Jul  4 06:04 /usr/pkg/share/gnulib/lib/gl_list.h
199483        4 -rw-r--r--    1 holo             holo                 2035 Jul  4 06:04 /usr/pkg/share/gnulib/lib/gl_linked_list.c
199956        2 -rw-r--r--    1 holo             holo                  212 Jul  4 06:04 /usr/pkg/share/gnulib/lib/userspec.h
199486        5 -rw-r--r--    1 holo             holo                 2865 Jul  4 06:04 /usr/pkg/share/gnulib/lib/gc-pbkdf2-sha1.c
199926       47 -rw-r--r--    1 holo             holo                38056 Jul  4 06:04 /usr/pkg/share/gnulib/lib/hash.c
...

$ gnulib-tool --update (on this repo - http://github.com/wrp/wscreen/tree/wrp )
Module list with included dependencies (indented):
    alignof
    alloca
    alloca-opt
...
File list:
  build-aux/arg-nonnull.h
  build-aux/c++defs.h
...
Creating directory ./lib
Creating directory ./build-aux
/usr/pkg/bin/gnulib-tool: *** file /usr/pkg/share/gnulib/top/GNUmakefile not found
/usr/pkg/bin/gnulib-tool: *** Stop.
>Fix:
--- a.diff begins here ---
Index: devel/gnulib/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/gnulib/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- devel/gnulib/Makefile	15 Jul 2010 05:55:07 -0000	1.6
+++ devel/gnulib/Makefile	14 Aug 2010 13:40:11 -0000
@@ -43,8 +43,8 @@ do-install:
 		do ${INSTALL_SCRIPT} ${WRKSRC}/$$p ${DATADIR};\
 		cd ${PREFIX}/bin && ${LN} -s ${DATADIR}/$$p;\
 		done
-	cd ${WRKSRC} && \
-		${CP} -Rp build-aux config doc lib m4 modules tests ${DATADIR}/
+	${TAR} cf - -C${WRKSRC} build-aux config doc lib m4 modules \
+		tests top | ${TAR} xof - -C${DATADIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/gnulib.info ${PREFIX}/${INFO_PATH}
 .ifndef		NOPORTDOCS
 	${MKDIR} ${DOCSDIR}
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: