ports/138846: www/apache22 mod_proxy optional patch is not applied by the Makefile

[George D.]

>Number:         138846
>Category:       ports
>Synopsis:       www/apache22 mod_proxy optional patch is not applied by the Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 15 15:20:07 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     George D.
>Release:        FreeBSD 7.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Tue May 12 07:24:33 EDT 2009 gi at serv.azagal.com:/usr/obj/usr/src/sys/serv_KERN i386

>Description:
	The optional patch for the mod_proxy_connect which can be enabled and disabled throught the config options is not getting applied
	regardless of whether the option is turned on or off.
	This is happening because the Makefile is checking for a wrong variable and not setting the EXTRA_PATCHES variable.
>How-To-Repeat:
	The following steps reproduce the issue:
	- cd into the www/apache22 folder
	- run "make extract"
	- save the modules/proxy/mod_proxy_connect.c file to a different location
	- run "make config"
	- check that the PATCH_PROXY_CONNECT option is turned on
	- run "make patch"
	- check that the modules/proxy/mod_proxy_connect.c file has not changed compared to the original file
>Fix:

	Apply the following patch to the www/apache22/Makefile :

--- Makefile.org        2009-09-15 08:35:07.000000000 -0400
+++ Makefile    2009-09-15 08:35:32.000000000 -0400
@@ -189,7 +189,7 @@ show-options:
        @${SED} -ne 's/^##//p' ${APACHEDIR}/Makefile.doc

 #optionally enable mod_proxy_connect patch
-.if defined(PATCH_PROXY_CONNECT)
+.if defined(WITH_PATCH_PROXY_CONNECT)
 EXTRA_PATCHES+= ${FILESDIR}/opt-patch-modules:proxy:mod_proxy_connect.c
 .endif



>Release-Note:
>Audit-Trail:
>Unformatted: