ports/131955: multimedia/libxine links libfaad.so.2 if present

[Jan Henrik Sylvester]

>Number:         131955
>Category:       ports
>Synopsis:       multimedia/libxine links libfaad.so.2 if present
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 21 23:10:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Jan Henrik Sylvester
>Release:        7.1-RELEASE-p3 i386
>Organization:
>Environment:
>Description:
If libfaad.so.2 from audio/faad is installed, multimedia/libxine uses it instead of building the internal one. The dependency is not recorded.

There should be an OPTION, if the internal or external libfaad is to be used.

It could default to off, since the dependency was not in the default package before.

Or it could default to on, since configure states:

--with-external-libfaad use external libfaad (recommended)

>How-To-Repeat:
- install audio/faad
- install multimedia/libxine
- readelf -d /usr/local/lib/xine/plugins/1.24/xineplug_decode_faad.so
- observe that libfaad.so.2 is NEEDED

>Fix:
The patch attached adds an OPTION WITH_FAAD that will configure --with-external-libfaad=yes and record the dependency if on and configure --with-external-libfaad=no otherwise. (The default is off to be conservative, but that is against recommendation in configure.)


Patch attached with submission follows:

diff -u multimedia/libxine/Makefile.orig multimedia/libxine/Makefile
--- multimedia/libxine/Makefile.orig	2009-02-10 20:50:54.000000000 +0100
+++ multimedia/libxine/Makefile	2009-02-21 23:20:56.000000000 +0100
@@ -63,7 +63,8 @@
 		AALIB "Enable aalib support" off \
 		IMAGEMAGICK "Enable ImageMagick support" off \
 		GTK2 "Enable gdkpixbuf support" off \
-		WAVPACK "Enable WavPack support" on
+		WAVPACK "Enable WavPack support" on \
+		FAAD "Enable external faad support" off
 
 MAN1=	xine-config.1 xine-list-1.1.1
 MAN5=	xine.5
@@ -177,6 +178,13 @@
 CONFIGURE_ARGS+=	--without-wavpack
 .endif
 
+.if defined(WITH_FAAD)
+LIB_DEPENDS+=	faad.2:${PORTSDIR}/audio/faad
+CONFIGURE_ARGS+=	--with-external-libfaad=yes
+.else
+CONFIGURE_ARGS+=	--with-external-libfaad=no
+.endif
+
 .if ${CONFIGURE_ARGS:M*--without-imagemagick*} == "" || ${CONFIGURE_ARGS:M*-disable-gdkpixbuf*} == ""
 PLIST_SUB+=	WITH_DMX_IMAGE=""
 .else


>Release-Note:
>Audit-Trail:
>Unformatted: