ports/138373: www/apache22 accf_data required at apache startup

[Helmut Schneider]

>Number:         138373
>Category:       ports
>Synopsis:       www/apache22 accf_data required at apache startup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 31 09:20:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Helmut Schneider
>Release:        7.2-RELEASE
>Organization:
>Environment:
>Description:
Since the upgrade from 2.2.11 to 2.2.13 there is a warning when starting apache:

[Mon Aug 31 11:09:04 2009] [warn] (2)No such file or directory: Failed to enable the 'dataready' Accept Filter
>How-To-Repeat:

>Fix:
--- apache22    2009-08-31 00:05:15.000000000 +0200
+++ /usr/local/etc/rc.d/apache22        2009-08-31 10:58:58.000000000 +0200
@@ -49,21 +49,14 @@
 [ -z "$apache22_fib" ] && apache22_fib="NO"

 apache22_accf() {
-       retcode=0
        if checkyesno apache22_http_accept_enable
        then
-               /sbin/kldstat -v | grep accf_http >/dev/null 2>&1
-               retcode=${?}
-               if [ ${retcode} -ne 0 ]
-               then
-                       /sbin/kldload accf_http 2> /dev/null
-                       retcode=${?}
-               fi
+               /sbin/kldstat -v | grep accf_http > /dev/null 2>&1 || /sbin/kldload accf_http || return ${?}
+               /sbin/kldstat -v | grep accf_data > /dev/null 2>&1 || /sbin/kldload accf_data || return ${?}
        else
                apache22_flags="${apache22_flags} -DNOHTTPACCEPT"
        fi
-       [ ${retcode} -ne 0 ] && echo "Unable to load accf_http module"
-       return ${retcode}
+       return 0
 }

 load_rc_config $name


>Release-Note:
>Audit-Trail:
>Unformatted: