ports/133960: [patch]: databases/phpmyadmin depends on filter

[Matthew Seaman]

The following reply was made to PR ports/133960; it has been noted by GNATS.

From: Matthew Seaman <m.seaman at infracaninophile.co.uk>
To: bug-followup at FreeBSD.ORG
Cc:  
Subject: Re: ports/133960: [patch]: databases/phpmyadmin depends on filter
Date: Fri, 24 Apr 2009 07:27:04 +0100

 On Fri, Apr 24, 2009 at 05:50:43AM +0000, Edwin Groothuis wrote:
 > Maintainer of databases/phpmyadmin,
 > 
 > Please note that PR ports/133960 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133960
 > 
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin at FreeBSD.org
 
 This is a correct patch, but when testing I found some more missing
 library functions.  Could you use this patch instead:
 
 diff -Nur /usr/ports/databases/phpmyadmin/Makefile phpmyadmin/Makefile
 --- /usr/ports/databases/phpmyadmin/Makefile	2009-04-16 06:18:03.000000000 +0100
 +++ phpmyadmin/Makefile	2009-04-24 07:19:56.000000000 +0100
 @@ -7,6 +7,7 @@
  
  PORTNAME=	phpMyAdmin
  DISTVERSION=	3.1.3.2
 +PORTREVISION=	1
  CATEGORIES=	databases www
  MASTER_SITES=	SF/phpmyadmin
  DISTNAME=	${PORTNAME}-${DISTVERSION}-all-languages
 @@ -20,7 +21,7 @@
  USE_BZIP2=	yes
  NO_BUILD=	yes
  .if !defined(WITHOUT_PHP_DEPENDS)
 -USE_PHP=	ctype mysql session spl
 +USE_PHP=	ctype mysql session spl filter
  .endif
  
  # Unfortunately can't make WITH_SUPHP part of the OPTIONS selection,
 @@ -79,7 +80,8 @@
  		PDF	 "PDFlib support (implies GD)" on \
  		ZLIB	 "ZLIB support" on \
  		MCRYPT   "MCrypt library support" on \
 -		MBSTRING "Multi-byte character-set string support" on
 +		MBSTRING "Multi-byte character-set string support" on \
 +		ZIP      "Zip compression support" on
  
  PORT_DBDIR?=	/var/db/ports
  LATEST_LINK=	${PORTNAME}${PKGNAMESUFFIX}
 @@ -91,7 +93,7 @@
  
  .if !defined(WITHOUT_PHP_DEPENDS)
  # Options that default to on:
 -.for opt in BZ2 GD OPENSSL PDF ZLIB MCRYPT MBSTRING
 +.for opt in BZ2 GD OPENSSL PDF ZLIB MCRYPT MBSTRING ZIP
  .    if !defined(WITHOUT_${opt}) || defined(WITH_${opt})
  USE_PHP+=	${opt:L}
  .    endif
 
 	Cheers,
 
 	Matthew
 
 -- 
 Dr Matthew J Seaman MA, D.Phil.                   7 Priory Courtyard
                                                   Flat 3
 PGP: http://www.infracaninophile.co.uk/pgpkey     Ramsgate
                                                   Kent, CT11 9PW