ports/133856: graphics/lcms: build of kde-koffice3 fails with lcms-1.18, 1

[Scot Hetzel]

>Number:         133856
>Category:       ports
>Synopsis:       graphics/lcms: build of kde-koffice3 fails with lcms-1.18,1
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 19 14:40:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Scot Hetzel
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010.hetzel.org 8.0-CURRENT FreeBSD 8.0-CURRENT #9: Tue Apr 14 06:10:39 CDT 2009     root at hp010.hetzel.org:/usr/obj/usr/src/sys/DV8135NR  amd64
>Description:
The build of editors/kde-koffice3 fails due to a missing liblcms.la.  The cause of the problem is that the upgrade of the graphics/lcms port to version 1.18, included a change to remove the install of the static library and the liblcms.la file.
>How-To-Repeat:
cd /usr/ports/graphics/lcms
make install
cd /usr/ports/editors/kde-koffice3
make build

/bin/sh /usr/local/bin/libtool --silent --tag=CXX --mode=link c++ 
-Wno-long-long -Wundef -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 
-O2 -fno-strict-aliasing -pipe -Wno-non-virtual-dtor -fno-exceptions 
-fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST 
-DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DHAVE_KNEWSTUFF 
-fexceptions  -L/usr/local/lib -o libkritagmagickimport.la -rpath 
/usr/local/lib/kde3 -avoid-version -module -no-undefined  -R 
/usr/local/lib -R /usr/local/lib -R /usr/local/lib -R /usr/local/lib -R 
/usr/local/lib-D_THREAD_SAFE -pthread -L/usr/local/lib -L/usr/local/lib 
-L/usr/local/lib -R/usr/local/lib -L/usr/local/lib -L/usr/local/lib -R 
/usr/local/lib -R /usr/local/lib -R /usr/local/lib -R /usr/local/lib -R 
/usr/local/lib  -L/usr/local/lib   -D_THREAD_SAFE -pthread 
-L/usr/local/lib -module -avoid-version -no-undefinedmagickimport.lo 
kis_image_magick_converter.lo ../../../lib/kofficeui/libkofficeui.la 
./../../lib/kofficecore/libkofficecore.la 
./../../lib/store/libkstore.la -lGraphicsMagick -ljbig -llcms -ltiff 
-lfreetype -ljasper -ljpeg -lpng -lfpx-lwmflite -lXext -lSM -lICE -lX11 
-lbz2 -lxml2 -lz -lm ../../../krita/libkritacommon.la 
-Wl,-export-dynamic -L/usr/local/lib -ljpeg  -L/usr/local/lib
grep: /usr/local/lib/liblcms.la: No such file or directory
sed: /usr/local/lib/liblcms.la: No such file or directory
libtool: link: `/usr/local/lib/liblcms.la' is not a valid libtool archive
gmake[4]: *** [libkritagmagickimport.la] Error 1
gmake[4]: Leaving directory 
`/usr/ports/editors/koffice-kde3/work/koffice-1.6.3/filters/krita/gmagick'


>Fix:
The attached fix, allows both the static library and the liblcms.la files to be installed.

By default the static library is not installed.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/lcms/Makefile,v
retrieving revision 1.30
diff -u -r1.30 Makefile
--- Makefile	7 Apr 2009 12:19:01 -0000	1.30
+++ Makefile	19 Apr 2009 14:28:20 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	lcms
 PORTVERSION=	1.18
-PORTREVISION=	0
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	graphics
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE} \
@@ -25,7 +25,8 @@
 USE_LDCONFIG=	yes
 
 OPTIONS=	TIFFICC "Build color profile applier for tiff" off \
-		JPEGICC "Build color profile applier for JPEG" off
+		JPEGICC "Build color profile applier for JPEG" off \
+		STATIC "Build static liblcms.a library" off
 
 .include <bsd.port.pre.mk>
 
@@ -47,19 +48,20 @@
 PLIST_SUB+=	JPEGICC="@comment "
 .endif
 
+.if defined(WITH_STATIC)
+PLIST_SUB+=	STATICLIB=""
+.else
+# Disable the build/install of the static liblcms.a library.
+CONFIGURE_ARGS+= --enable-static="no"
+PLIST_SUB+=	STATICLIB="@comment "
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e \
 		's|^SUBDIRS =.*$$|SUBDIRS = src include|g' ${WRKSRC}/Makefile.in
 	@${REINPLACE_CMD} -e \
 		's|-O3||g' ${WRKSRC}/src/Makefile.in
 
-#
-# Get rid of .la and static library files
-#
-post-configure:
-	@${REINPLACE_CMD} -E -e \
-	    '/Install the pseudo-library/,/staticlibs=/s,^,#,' ${WRKSRC}/libtool
-
 post-install:
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/graphics/lcms/pkg-plist,v
retrieving revision 1.12
diff -u -r1.12 pkg-plist
--- pkg-plist	7 Apr 2009 12:19:01 -0000	1.12
+++ pkg-plist	19 Apr 2009 14:10:30 -0000
@@ -3,6 +3,8 @@
 %%TIFFICC%%bin/tifficc
 include/icc34.h
 include/lcms.h
+%%STATICLIB%%lib/liblcms.a
+lib/liblcms.la
 lib/liblcms.so
 lib/liblcms.so.1
 libdata/pkgconfig/lcms.pc


>Release-Note:
>Audit-Trail:
>Unformatted: