ports/133704: apache22 apxs does not work as expected

[olli hauer]

>Number:         133704
>Category:       ports
>Synopsis:       apache22 apxs does not work as expected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 13 12:30:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     ohauer
>Release:        FreeBSD 7.1-RELEASE-p4 i386
>Organization:
>Environment:


>Description:
There is a miss behavior in the apxs script from apache22 (other versions not tested)

If you install a apache22 the LoadModule lines look like the following

 LoadModule *whitespace* ${modulename}_module *whitespace* libexec/apache22/mod_${modulename}.so

If you try now to activate/deactivate a module with apxs the result will differ from what you expect

>How-To-Repeat:

For the following test I will pick a long and two short module name (ssl autoindex cgi)

$> grep -e autoindex_ -e cgi_ httpd.conf
LoadModule autoindex_module libexec/apache22/mod_autoindex.so
LoadModule cgi_module libexec/apache22/mod_cgi.so


fire up the following commands

$> apxs -e -a -n autoindex mod_autoindex.so
[activating module `autoindex' in /usr/local/etc/apache22/httpd.conf]
$> apxs -e -a -n cgi mod_cgi.so
[activating module `cgi' in /usr/local/etc/apache22/httpd.conf]

This will result into the following httpd.conf

$> grep -e autoindex_ -e cgi_ httpd.conf
LoadModule autoindex_module libexec/apache22/mod_autoindex.so
LoadModule cgi_module libexec/apache22/mod_cgi.so
LoadModule autoindex_module   libexec/apache22/mod_autoindex.so
LoadModule cgi_module         libexec/apache22/mod_cgi.so


As you notice the modules are now loaded twice

Now try to deactivate for the loaded ssl module

$> grep ssl_ httpd.conf
LoadModule ssl_module libexec/apache22/mod_ssl.so

$> apxs -e -A -n ssl mod_ssl.so
[preparing module `ssl' in /usr/local/etc/apache22/httpd.conf]

$> grep ssl_ httpd.conf
LoadModule ssl_module libexec/apache22/mod_ssl.so
#LoadModule ssl_module         libexec/apache22/mod_ssl.so

Instead to deactivate the module a new line will be insert

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: