ports/128420: port www/opera operapluginwrapper misparses command line

[G. Paul Ziemba]

>Number:         128420
>Category:       ports
>Synopsis:       port www/opera operapluginwrapper misparses command line
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 27 17:50:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     G. Paul Ziemba
>Release:        6.2-STABLE
>Organization:
>Environment:
FreeBSD hairball.ziemba.us 6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Jun  3 19:55:09 PDT 2007     root at hairball:/usr/obj/usr/src/sys/GPZ-070603  i386
>Description:
% pkg_info|grep opera
opera-9.60.20081004_1 Blazingly fast, full-featured, standards-compliant browser,
opera-linuxplugins-9.60.20081004 Linux plugin support for the native Opera browser

/usr/local/share/opera/bin/operapluginwrapper is called with arguments:
detect -fd 81 -v /usr/local/lib/npapi/linux-flashplugin/libflashplayer.so

It does not handle the case where the plugin filename is in $5, so calls brandelf only as "brandelf -v", which is bogus. Plugin detection fails, since
this plugin is SVR4 but is treated as a FreeBSD-branded file.
>How-To-Repeat:

>Fix:
patch ports/www/opera/files/operapluginwrapper:
--- operapluginwrapper.old      Thu Oct 16 18:07:50 2008
+++ operapluginwrapper  Mon Oct 27 10:28:47 2008
@@ -1,6 +1,8 @@
 #!/bin/sh
 
-if [ -n "$4" ]; then
+if [ -n "$5" ]; then
+ELFTYPE=`brandelf $5`
+elif [ -n "$4" ]; then
 ELFTYPE=`brandelf $4`
 elif [ -n "$3" ]; then
 ELFTYPE=`brandelf $3`


>Release-Note:
>Audit-Trail:
>Unformatted: