ports/123327: Port fix: graphics/libcaca - CONFIGURE_ENV incorrectly set

[Ganael Laplanche]

>Number:         123327
>Category:       ports
>Synopsis:       Port fix: graphics/libcaca - CONFIGURE_ENV incorrectly set
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 02 10:00:11 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ganael Laplanche
>Release:        7.0-STABLE
>Organization:
http://contribs.martymac.com
>Environment:
FreeBSD home.martymac.com 7.0-STABLE FreeBSD 7.0-STABLE #15: Wed Apr 30 22:06:57 CEST 2008     root at home.martymac.com:/usr/obj/usr/src/sys/MYKERNEL  amd64
>Description:
Hi,

Revision 1.22 of the port's Makefile of libcaca introduces the use of USE_EFL instead of LIB_DEPENDS. Unfortunately, bsd.efl.mk overrides CONFIGURE_ENV using LDFLAGS, but the port's Makefile does not define this variable. This leads to an incorrect CONFIGURE_ENV, as you can see :

% pwd
/usr/ports/graphics/libcaca
% make -V CONFIGURE_ENV
CPPFLAGS="-I/usr/local/include"  LDFLAGS="-L/usr/local/lib -lm -lncurses" SHELL=/bin/sh CONFIG_SHELL=/bin/sh CPPFLAGS="-I/usr/local/include"  CFLAGS="-I/usr/local/include -O -pipe
 -march=nocona"  LDFLAGS="-L/usr/local/lib "   LIBTOOL=/usr/local/bin/libtool LIBTOOLIZE=/usr/local/bin/libtoolize LIBTOOL_M4=/usr/local/share/aclocal/libtool.m4     lt_cv_sys_max
_cmd_len=262144

LDFLAGS appears twice with a wrong value on the second time, so the port is no more linked against -lm and -lncurses.

The attached patch uses LDFLAGS and CPPFLAGS variables to be bsd.efl.mk-friendly.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -aurN libcaca.orig/Makefile libcaca/Makefile
--- libcaca.orig/Makefile	2008-05-02 11:40:11.118343558 +0200
+++ libcaca/Makefile	2008-05-02 11:40:43.246650927 +0200
@@ -17,8 +17,10 @@
 USE_GNOME=	gnomehack gnometarget ltverhack pkgconfig
 USE_LDCONFIG=	yes
 USE_AUTOTOOLS=	libtool:15
-CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
-		LDFLAGS="-L${LOCALBASE}/lib -lm -lncurses"
+CPPFLAGS=	-I${LOCALBASE}/include
+LDFLAGS=	-L${LOCALBASE}/lib -lm -lncurses
+CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" \
+		LDFLAGS="${LDFLAGS}"
 CONFIGURE_ARGS=	--disable-doc \
 		--enable-ncurses \
 		--disable-csharp \


>Release-Note:
>Audit-Trail:
>Unformatted: