ports/121453: [patch] improve Mk/bsd.sites.mk MASTER_SITE_GOOGLE_CODE variable

[Dmitry Marakasov]

The following reply was made to PR ports/121453; it has been noted by GNATS.

From: Dmitry Marakasov <amdmi3 at amdmi3.ru>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: ports/121453: [patch] improve Mk/bsd.sites.mk
	MASTER_SITE_GOOGLE_CODE variable
Date: Sat, 8 Mar 2008 00:26:39 +0300

 * Edwin Groothuis (edwin at mavetju.org) wrote:
 
 > >  >  > I submitted this as a PR instead of just commited it because it
 > >  >  > might cause some controvacy.
 > >  >  I will commit this patch in the next week if I don't receibe any
 > >  >  negative replies on it.
 > >  Can't MASTER_SITE_SUBDIR be used for that cases? I think using
 > >  MASTER_SITE_SUBDIR for not-actually-a-subdir is a less pain than
 > >  introducing a new variable.
 > I have looked at it, but I couldn't really find a way to get it
 > added as the default.
 > 
 > The current code is:
 > 
 >     MASTER_SITES_GOOGLE_CODE=	http://${PORTNAME}.googlecode.com/files
 > 
 > This one works for 75% of the ports.
 > 
 > If we would use the following code:
 > 
 >     MASTER_SITES_GOOGLE_CODE=	http://%%SUBDIR%%.googlecode.com/files
 > 
 > we would need to set MASTER_SITE_SUBDIR for all of them. But strictly
 > speaking, it isn't a real sub-directory to start with.
 If changed to MASTER_SITES_GOOGLE_CODE= http://${GOOGLENAME}.googlecode...
 GOOGLENAME should be defined for each port as well (unless defined as
 GOOGLENAME?=	${PORTNAME}
 ). Well, on the other hand, if you see `less painful' as `as little ports
 modified as possible', this GOOGLENAME stuff is OK.
 
 My idea is that we'd better have only one variable with meaning `project
 name on specific multi-project site', which defaults to ${PORTNAME} and
 may be overridden if needed. As of now, MASTER_SITE_SUBDIR has this
 meaning in many cases.
 
 -- 
 Dmitry A. Marakasov    | jabber: amdmi3 at jabber.ru
 amdmi3 at amdmi3.ru       | http://www.amdmi3.ru