ports/121431: devel/ccrtp doesn't build with security/libgcrypt 1.4.0 on FreeBSD 5.x

[Jonathan Lennox]

>Number:         121431
>Category:       ports
>Synopsis:       devel/ccrtp doesn't build with security/libgcrypt 1.4.0 on FreeBSD 5.x
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 06 16:10:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Lennox
>Release:        FreeBSD 5.5-RELEASE-p19 i386
>Organization:
Columbia University
>Environment:
System: FreeBSD cnr.cs.columbia.edu 5.5-RELEASE-p19 FreeBSD 5.5-RELEASE-p19 #26: Thu Feb 14 12:09:09 EST 2008 lennox at cnr.cs.columbia.edu:/usr/obj/usr/src/sys/CNR i386


	
>Description:

With version 1.4.0 of security/libgcrypt, the devel/ccrtp port doesn't build
on FreeBSD 5.x.

This appears to be due to devel/ccrtp building as C++ with the -pedantic
flag, while gcrypt.h has enumerator lists (gcry_ac_em_t and
gcry_ac_scheme_t) with trailing commas.  This causes a compiler error with
the FreeBSD 5.x g++.

/bin/sh ../libtool --tag=CXX   --mode=compile c++ -DHAVE_CONFIG_H -I.   -I/usr/local/include  -Wall -ansi -pedantic -O -pipe -march=athlon-xp -D_THREAD_SAFE -D_GNU_SOURCE -I/usr/local/include   -c -o gcrypthmac.lo `test -f 'ccrtp/crypto/gcrypt/gcrypthmac.cxx' || echo './'`ccrtp/crypto/gcrypt/gcrypthmac.cxx
 c++ -DHAVE_CONFIG_H -I. -I/usr/local/include -Wall -ansi -pedantic -O -pipe -march=athlon-xp -D_THREAD_SAFE -D_GNU_SOURCE -I/usr/local/include -c ccrtp/crypto/gcrypt/gcrypthmac.cxx  -fPIC -DPIC -o .libs/gcrypthmac.o
In file included from ccrtp/crypto/gcrypt/gcrypthmac.cxx:23:
/usr/local/include/gcrypt.h:1238: error: comma at end of enumerator list
/usr/local/include/gcrypt.h:1246: error: comma at end of enumerator list
gmake[3]: *** [gcrypthmac.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake: *** [all-recursive] Error 1
*** Error code 2

Stop in /usr/ports/devel/ccrtp.


This issue has been reported to the libgcrypt bug tracker.

>How-To-Repeat:

portupgrade security/libgcrypt
portinstall -f devel/ccrtp

>Fix:

The proper fix should probably be to the security/libgcrypt port, but adding
the following patch file to devel/ccrtp/files fixes the ccrtp build:

--- configure.orig	Thu Mar  6 10:40:11 2008
+++ configure	Thu Mar  6 10:40:20 2008
@@ -20904,7 +20904,7 @@ GNULIBS="-L$COMMON_LIBPATH $COMMON_LIBS 
 # OST_CC_ENDIAN - now in Common C++
 # Are we using the GNU compiler?
 if test $GCC = yes ; then
-	WARN_FLAGS="-Wall -ansi -pedantic"
+	WARN_FLAGS="-Wall -ansi"
 else
 	WARN_FLAGS=""
 fi



>Release-Note:
>Audit-Trail:
>Unformatted: