ports/125056: Unnecessary msync() call kills databases/rrdtool performance under FreeBSD

[Razor]

The following reply was made to PR ports/125056; it has been noted by GNATS.

From: Razor <bg1tpt at gmail.com>
To: bug-followup at freebsd.org, marcus at blazingdot.com
Cc:  
Subject: Re: ports/125056: Unnecessary msync() call kills databases/rrdtool performance under FreeBSD
Date: Mon, 30 Jun 2008 11:58:40 +0800

 ------=_Part_499_13284543.1214798320563
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 The patch has been approved. The msync is unnecessary for FreeBSD. But
 the madvise is useful for big files? Please place the
 patch-src__rrd_open.c to the rrdtool/files directory.
 
 On Mon, Jun 30, 2008 at 2:18 PM, Edwin Groothuis <edwin at freebsd.org> wrote:
 > Maintainer of databases/rrdtool,
 >
 > Please note that PR ports/125056 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125056
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin at FreeBSD.org
 >
 
 ------=_Part_499_13284543.1214798320563
 Content-Type: application/octet-stream; name=patch-src__rrd_open.c
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_fi2jfq0b0
 Content-Disposition: attachment; filename=patch-src__rrd_open.c
 
 LS0tIC4vc3JjL3JyZF9vcGVuLmMub3JpZwkyMDA4LTA2LTMwIDExOjQxOjUxLjAwMDAwMDAwMCAr
 MDgwMAorKysgLi9zcmMvcnJkX29wZW4uYwkyMDA4LTA2LTMwIDExOjQyOjA2LjAwMDAwMDAwMCAr
 MDgwMApAQCAtMzg4LDkgKzM4OCw2IEBACiAgICAgaW50ICAgICAgIHJldDsKIAogI2lmZGVmIEhB
 VkVfTU1BUAotICAgIHJldCA9IG1zeW5jKHJyZF9maWxlLT5maWxlX3N0YXJ0LCBycmRfZmlsZS0+
 ZmlsZV9sZW4sIE1TX0FTWU5DKTsKLSAgICBpZiAocmV0ICE9IDApCi0gICAgICAgIHJyZF9zZXRf
 ZXJyb3IoIm1zeW5jIHJyZF9maWxlOiAlcyIsIHJyZF9zdHJlcnJvcihlcnJubykpOwogICAgIHJl
 dCA9IG11bm1hcChycmRfZmlsZS0+ZmlsZV9zdGFydCwgcnJkX2ZpbGUtPmZpbGVfbGVuKTsKICAg
 ICBpZiAocmV0ICE9IDApCiAgICAgICAgIHJyZF9zZXRfZXJyb3IoIm11bm1hcCBycmRfZmlsZTog
 JXMiLCBycmRfc3RyZXJyb3IoZXJybm8pKTsK
 ------=_Part_499_13284543.1214798320563--